Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Test] NonPersistentTopicMessagingTest does not cover Non-Persistent topics #23541

Open
2 of 3 tasks
heesung-sn opened this issue Nov 1, 2024 · 1 comment
Open
2 of 3 tasks
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@heesung-sn
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Read release policy

  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

4.0

Minimal reproduce step

run NonPersistentTopicMessagingTest

What did you expect to see?

NonPersistentTopicMessagingTest should use non-persistent topics

What did you see instead?

NonPersistentTopicMessagingTest uses persistent topics

Anything else?

https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/messaging/MessagingBase.java#L57

https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/messaging/MessagingBase.java#L65

In the above test code, we don't pass the isPersistent input when generating topic names.

If I fix the above code and run the test, the test fails. There might be some bugs around here.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@heesung-sn heesung-sn added the type/bug The PR fixed a bug or issue reported a bug label Nov 1, 2024
@heesung-sn heesung-sn changed the title [Bug][test] NonPersistentTopicMessagingTest does not cover Non-Persistent topics [Bug][Test] NonPersistentTopicMessagingTest does not cover Non-Persistent topics Nov 1, 2024
@heesung-sn
Copy link
Contributor Author

In fact,
there are other tests impacted by this bug.

  • NonDurableConsumerMessagingTest
  • ReaderMessagingTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

No branches or pull requests

1 participant