Add SkyPredictor project to E2E Testing alarm with baseline #13047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrproliu
added
the
test
wu-sheng
reviewed
Feb 20, 2025
wu-sheng
reviewed
Feb 20, 2025
Comment on lines
+407
to
+412
| - name: Baseline-driven Alarm ES | ||
| config: test/e2e-v2/cases/baseline/es/e2e.yaml | ||
| - name: Baseline-driven Alarm ES Sharding | ||
| config: test/e2e-v2/cases/baseline/es/es-sharding/e2e.yaml | ||
| - name: Baseline-driven Alarm BanyanDB | ||
| config: test/e2e-v2/cases/baseline/banyandb/e2e.yaml |
There was a problem hiding this comment.
@wankai123 @kezhenxu94 According to discussion between Han and me, JDBC storage is not suitable for this, because the baseline is calculated based on historic data, which can't be inserted as JDBC tables are created for today only, can't be auto-created between TTL to Now. We have to skip that case.
But, logically, this process does not rely on storage implementation, we just read historic data through GraphQL, hence, we believe we should be good.
wu-sheng
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.