-
-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQL] Batch requests in Apollo format #3280
Comments
It would be nice to have this feature sure 🙂 |
Looks good to me as well 🙂 |
Curious if this was ever revisited? |
A very rough tweak to the GraphQL entrypoint action
I don't think query batching is necessary or even supported in graphql playground, so this can simply resolve for only the non-html requests to the gql endpoint. Seems like a really simple and quick implementation to utilising query batching. Sure, it doesn't save on db executions, but this does save on server overhead by cutting out many multiples of network requests that could be consolidated. |
Description
This Apollo extension allow us to send multiple request at the same time:
https://www.apollographql.com/docs/link/links/batch-http/
It will be a good feature to have since we don't support sub class mutation( because of Input union spec) and it force client to send several requests for one action.I think this plugin solve some part of performance issue.
Here is Apollo client Article:
https://blog.apollographql.com/query-batching-in-apollo-63acfd859862
This plugin changes the requests to this format:
I think we have two option to implement this part:
Using
StandardServer
This is good but we need to rewrite request process and remove the current GraphQl executor and replace it with
StandardServer
. BecauseStandardServer
don't support the file upload we need to process the requests just like before.Calling executor several times.
This is the easiest option for implementation.
I wanted to create a pull request for this, I thought its better to talk about it first.
What do you think?
The text was updated successfully, but these errors were encountered: