Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making commons a monorepo #89

Closed
Siegrift opened this issue May 14, 2024 · 2 comments
Closed

Consider making commons a monorepo #89

Siegrift opened this issue May 14, 2024 · 2 comments

Comments

@Siegrift
Copy link
Collaborator

This was suggested in #29 (comment) and in #4 (comment).

The idea is that the commons repo serves (or could) different purposes:

  1. Libraries and utilities - e.g. logger, blockchain utilities
  2. Dev tools - e.g. eslint
  3. Testing only libraries - e.g. some mock utilities, extensions to jest, cypress, chai, etc...
  4. Blueprints - e.g. ideal TS/jest,etc... configuration files

At the moment, only 1) and 2) are implemented and there are not immediate plans for 3) and 4). Migrating to the monorepo has advantages that we can have more focused packages, better bundle size (good for FE). However, it brings a significant overhead in terms releasing, versioning and also for consumers.

It's better to do this once the commons repo grows in size and there are going to be good reasons for this migration.

@Siegrift
Copy link
Collaborator Author

Siegrift commented Jul 2, 2024

Over time, there seems NOT to be an use case for this. We seem to be OK with just a single repo for the time being.

@Siegrift
Copy link
Collaborator Author

Even more time has passed, and there are still no use cases for this and the commons repo is still limited in size. I'm closing this and we can reopen this once we have a reason to migrate to monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant