feat!: Enable additional status codes arguments to PlaywrightCrawler #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they exist now on all crawlers, move them to basic crawler level.
github-actions
bot
added
t-tooling
Mantisus
reviewed
Feb 7, 2025
|
|
||
| if self._http_client.additional_blocked_status_codes != self._additional_http_error_status_codes: | ||
| raise ValueError( | ||
| 'Used `additional_blocked_status_codes` argument does not match with with ' |
There was a problem hiding this comment.
double with
Sorry, can't commit with the quick fix due to limited permissions.
vdusek
reviewed
Feb 10, 2025
Comment on lines
+292
to
+313
| self._additional_http_error_status_codes = ( | ||
| set(additional_http_error_status_codes) if additional_http_error_status_codes else set() | ||
| ) | ||
| self._ignore_http_error_status_codes = ( | ||
| set(ignore_http_error_status_codes) if ignore_http_error_status_codes else set() | ||
| ) | ||
|
|
||
| self._http_client = http_client or HttpxHttpClient( | ||
| additional_http_error_status_codes=self._additional_http_error_status_codes, | ||
| ignore_http_error_status_codes=self._ignore_http_error_status_codes, | ||
| ) | ||
|
|
||
| if self._http_client.additional_blocked_status_codes != self._additional_http_error_status_codes: | ||
| raise ValueError( | ||
| 'Used `additional_blocked_status_codes` argument does not match with ' | ||
| f'{self._http_client.additional_blocked_status_codes=}. They have to be the same.' | ||
| ) | ||
| if self._http_client.ignore_http_error_status_codes != self._ignore_http_error_status_codes: | ||
| raise ValueError( | ||
| 'Used `ignore_http_error_status_codes` argument does not match with ' | ||
| f'{self._http_client.ignore_http_error_status_codes=}. They have to be the same.' | ||
| ) |
There was a problem hiding this comment.
Couldn't we just keep them only in the http_client instance? (PW Crawler has HTTP client as well)
There was a problem hiding this comment.
I was considering that option, but it felt like misuse to me, especially when it comes to PlaywrightCrawler. PlaywrightCrawler is not using HTTP client for page.navigate so it would be really strange if it would use some attribute of this unrelated component to decide whether response status code of page.navigate is ok or not.
(Mentioned : #953 (comment))
But I see it looks like unnecessary code duplication, so I am not 100% happy with this either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
additional_http_error_status_codesandignore_http_error_status_codesto PlaywrightCrawler.Since they exist now on all crawlers, move them to
BasicCrawlerlevel.Do not use
_http_clientattributes for getting additional status codes related variables.Breaking: Remove
HttpCrawlerOptions-> No unique options compared toBasicCrawlerOptionsanymore.Issues