Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container putArchive open handle with Node v20 #728

Open
cristianrgreco opened this issue Apr 24, 2023 · 2 comments
Open

Container putArchive open handle with Node v20 #728

cristianrgreco opened this issue Apr 24, 2023 · 2 comments
Labels

Comments

@cristianrgreco
Copy link

cristianrgreco commented Apr 24, 2023

Hello, thanks for this lib!

I create and pass in a tar stream using archiver:

await options.container.putArchive(options.stream, { path: options.containerPath });

Node v12-18 works without issue. In node 20 this results in open handles

@cristianrgreco
Copy link
Author

cristianrgreco commented Apr 24, 2023

This can be worked around by simply consuming the stream, but there is a behavior difference between node versions:

const stream = await options.container.putArchive(options.stream, { path: options.containerPath });
for await (const chunk of stream) {}

Copy link

stale bot commented Nov 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Open a new issue if needed.

@stale stale bot added the stale label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant