Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse repeated syntax with loops instead of recursion #666

Closed
SimonSapin opened this issue Sep 27, 2023 · 0 comments · Fixed by #721
Closed

Parse repeated syntax with loops instead of recursion #666

SimonSapin opened this issue Sep 27, 2023 · 0 comments · Fixed by #721
Assignees
@goto-bus-stop
Labels
apollo-parser triage

Comments

@SimonSapin
Copy link
Contributor

SimonSapin commented Sep 27, 2023 •
edited
Loading

PR #662 made the parser recursion limit apply to every case recursion was used (hopefully i didn’t miss any). In same cases (nested selection set, nested values, arguably nested list types) recursion does make parsing significantly easier. But as of this writing recursion is also used in many case to parse repetition, where it could be easily replaced with a loop.

This issue is fixed if the test added by #662 still passes after uncommenting this assertion:

apollo-rs/crates/apollo-parser/src/parser/mod.rs

Line 636 in 865be96

// assert_eq!(ast.errors.len(), 0)

SimonSapin added a commit that referenced this issue Sep 27, 2023
@SimonSapin
fix(parser): apply recursion limit everywhere, reduce default to 500 (#…
865be96 
…662)

The limit was only tracked for nested selection sets, but the parser turns out
to use recursion in other cases too. Issue #666 tracks reducing them.
Stack overflow was observed with little more than 2000
nesting levels or repetitions in the new test.
Defaulting to a quarter of that leaves a comfortable margin.
@goto-bus-stop goto-bus-stop self-assigned this Nov 2, 2023
@goto-bus-stop goto-bus-stop mentioned this issue Nov 3, 2023
Merged
@bsaltz bsaltz mentioned this issue Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
apollo-parser triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(parser): remove recursion when parsing non-nested lists of nodes apollographql/apollo-rs
2 participants
@SimonSapin @goto-bus-stop