From 59b2b4a2884fdd5048955ea6ce82496ebfd2de25 Mon Sep 17 00:00:00 2001 From: apoorvkh Date: Fri, 12 Jul 2024 15:53:28 -0400 Subject: [PATCH] pyright fixes --- src/torchrunx/__init__.py | 2 ++ src/torchrunx/launcher.py | 12 +++++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/torchrunx/__init__.py b/src/torchrunx/__init__.py index 9bde09c..b811e65 100644 --- a/src/torchrunx/__init__.py +++ b/src/torchrunx/__init__.py @@ -1,3 +1,5 @@ +from __future__ import annotations + from .launcher import launch diff --git a/src/torchrunx/launcher.py b/src/torchrunx/launcher.py index ec8d8ef..3a2f45d 100644 --- a/src/torchrunx/launcher.py +++ b/src/torchrunx/launcher.py @@ -133,16 +133,18 @@ def launch( # launch command - env_export_string = "" env_exports = [] for k, v in os.environ.items(): - for e in env_vars: - if any(fnmatch.fnmatch(k, e)): - env_exports.append(f"{k}={v}") + if any(fnmatch.fnmatch(k, e) for e in env_vars): + env_exports.append(f"{k}={v}") + + env_export_string = "" if len(env_exports) > 0: env_export_string = f"export {' '.join(env_exports)} && " - env_file_string = f"source {env_file} && " if env_file is not None else "" + env_file_string = "" + if env_file is not None: + env_file_string = f"source {env_file} && " launcher_hostname = socket.getfqdn() launcher_port = get_open_port()