Support for ldap #6
Comments
|
What did you do exactly - did you wrap it in a new strategy that looks more
like passport-oauth2 from the outside? Might I have a look?
…On Wed, Mar 6, 2019 at 7:41 PM linden5 ***@***.***> wrote:
I want to use ldap to log into Apostrophe, and have tried
passport-ldapauth <https://www.npmjs.com/package/passport-ldapauth>. But
I found that there seem only to be support for passport strategies based on
passport-oauth2.
Though I solved the problem by extending passport-ldapauth myself, is it
possible to add support for other passport strategies not based on
passport-oauth2 officially?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AROF6LCTbzCQAxJZmr5tbSYHWEw2Vu6Iks5vUGAzgaJpZM4biHQN>
.
--
*Thomas Boutell, Chief Software Architect*
P'unk Avenue | (215) 755-1330 | punkave.com
|
|
It is true that we were naive about the degree of consistency in passport
module configuration. We wound up creating a separate apostrophe-saml
module because the interfaces are so different.
…On Wed, Mar 6, 2019, 8:16 PM Tom Boutell ***@***.***> wrote:
What did you do exactly - did you wrap it in a new strategy that looks
more like passport-oauth2 from the outside? Might I have a look?
On Wed, Mar 6, 2019 at 7:41 PM linden5 ***@***.***> wrote:
> I want to use ldap to log into Apostrophe, and have tried
> passport-ldapauth <https://www.npmjs.com/package/passport-ldapauth>. But
> I found that there seem only to be support for passport strategies based on
> passport-oauth2.
> Though I solved the problem by extending passport-ldapauth myself, is it
> possible to add support for other passport strategies not based on
> passport-oauth2 officially?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#6>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AROF6LCTbzCQAxJZmr5tbSYHWEw2Vu6Iks5vUGAzgaJpZM4biHQN>
> .
>
--
*Thomas Boutell, Chief Software Architect*
P'unk Avenue | (215) 755-1330 | punkave.com
|
|
That's right, I wrapped it in a new strategy that looks more like passport-oauth2 from the outside. The keypoint is adding username, displayName to user profile, and passing it properly to the verify function returned by the method findOrCreateUser. |
|
Sweet! Yes, I'd love to use it as a documentation example.
…On Thu, Mar 7, 2019 at 8:20 PM linden5 ***@***.***> wrote:
That's right, I wrapped it in a new strategy that looks more like
passport-oauth2 from the outside. The keypoint is adding username,
displayName to user profile, and passing it properly to the verify function
returned by the method *findOrCreateUser*.
I think your design is reasonable since oauth2 is widely used.
I will post my code later. Thank you for your reply.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB9fQYomPmugz4P0B2AFgPuNe70Q7EGks5vUbrlgaJpZM4biHQN>
.
--
*Thomas Boutell, Chief Software Architect*
P'unk Avenue | (215) 755-1330 | punkave.com
|
|
I've committed my code here. If you have any suggestions, please let me know. |
|
After investigating further, I found apostrophe-ldap-login. While it solves my problem, extra work is needed to create users. |
|
That module, which is not one of ours (thanks for bringing it to my
attention), is for Apostrophe 0.5 and will not work with 2.x.
…On Thu, Mar 14, 2019 at 10:18 AM linden5 ***@***.***> wrote:
After investigating further, I found apostrophe-ldap-login
<https://github.com/aesora/apostrophe-ldap-login>. It solves my problem
too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AROF6N-3jns7RWCC1hEDhsJpPd-7-AQ8ks5vWlo3gaJpZM4biHQN>
.
--
*Thomas Boutell, Chief Software Architect*
P'unk Avenue | (215) 755-1330 | punkave.com
|
|
Did you abandon your own solution to use apostrophe-ldap-login somehow (you'd have to port it to 2.x)? Curious how this worked out for you. |
|
No, I didn't abandon my own solution. I left my previous comment before actually trying that module or taking a look at the source code. I should have been more rigorous. |
|
Oh, no worries, just curious!
…On Tue, Mar 19, 2019 at 2:29 AM linden5 ***@***.***> wrote:
No, I didn't abandon my own solution. I left my previous comment before
actually trying that module or taking a look at the source code. I should
have been more rigorous.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB9fag_3W-fMkEizfDWfKBdUIk5yTVtks5vYIPCgaJpZM4biHQN>
.
--
*Thomas Boutell, Chief Software Architect*
P'unk Avenue | (215) 755-1330 | punkave.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to use ldap to log into Apostrophe, and have tried passport-ldapauth. But I found that there seems only to be support for passport strategies based on passport-oauth2.
Though I solved the problem by extending passport-ldapauth myself, is it possible to add support for other passport strategies not based on passport-oauth2 officially?
The text was updated successfully, but these errors were encountered: