Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

allow ports to be included in an image name #628

Closed
cgonyeo opened this issue Jun 16, 2016 · 4 comments
Closed

allow ports to be included in an image name #628

cgonyeo opened this issue Jun 16, 2016 · 4 comments

Comments

@cgonyeo
Copy link
Member

cgonyeo commented Jun 16, 2016

An issue (appc/acpush#6) was recently filed against acpush where the user wished to set the image name to refer to a non-default port on a host (e.g. aci-serv:3000/tester). Right now the : character is not allowed in image names, and allowing it would make version parsing a little more complicated. Is this something that should be fixed?

@jonboulle
Copy link
Contributor

This would couple name to transport which is pretty much directly against the intentions of the spec. Why can't we use a flag for ports?

@jonboulle
Copy link
Contributor

Danced around in #110

@cgonyeo
Copy link
Member Author

cgonyeo commented Jun 17, 2016

Yup, looks like that would solve this. I can add a port flag to acpush once that gets merged.

Although on the subject of coupling name to transport, I thought rkt already complained if the image name didn't match where it pulled the image from? As in, if I rkt fetch coreos.com/etcd and the image manifest it gets back has the name quay.io/coreos/etcd, that rkt would error out?

@jonboulle
Copy link
Contributor

That's not coupling to a particular transport mechanism per se - rather, it's ensuring the way the image is referenced matches what the contents are. I admit that this is a little blurry and something abd was trying to make much more specific.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants