Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fish completion script generation #737

Open
rgoldberg opened this issue Feb 16, 2025 · 0 comments · May be fixed by #738
Open

Improve fish completion script generation #737

rgoldberg opened this issue Feb 16, 2025 · 0 comments · May be fixed by #738

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Feb 16, 2025 •
edited
Loading

Improve fish completion script generation.

There are many issues with script generation. Some of them are documented in #679 & its comments.

This issue is for a first batch of fish completion script fixes.

I will submit a PR. Each commit should note the fix(es) that it contains.

After the PR for this issue is merged, I will sequentially create issues & submit PRs for cross-shell changes, then I will migrate the 3 shells to ToolInfo (unless @rauhul wants to do it), then I will resume working on more fixes (though I'm happy to pause if any of you want to modify the completion code or anything that interacts with it).
rgoldberg added a commit to rgoldberg/swift-argument-parser that referenced this issue Feb 16, 2025
@rgoldberg
Improve custom completion args for fish 4+.
0cf923d 
Resolve apple#737

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg linked a pull request Feb 16, 2025 that will close this issue
Open
4 tasks
rgoldberg added a commit to rgoldberg/swift-argument-parser that referenced this issue Feb 16, 2025
@rgoldberg
Improve custom completion args for fish 4+.
ec9f112 
Resolve apple#737

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg mentioned this issue Feb 16, 2025
Open
rgoldberg added a commit to rgoldberg/swift-argument-parser that referenced this issue Feb 19, 2025
@rgoldberg
Improve custom completion args for fish 4+.
d89069c 
Resolve apple#737

Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg added a commit to rgoldberg/swift-argument-parser that referenced this issue Feb 25, 2025
@rgoldberg
Improve custom completion args for fish 4+.
cec99b0 
Resolve apple#737

Signed-off-by: Ross Goldberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve fish completion script generation rgoldberg/swift-argument-parser
1 participant
@rgoldberg