Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding maven generation support #1163

Open
Paul-Etienne opened this issue Sep 3, 2021 · 5 comments
Open

Adding maven generation support #1163

Paul-Etienne opened this issue Sep 3, 2021 · 5 comments

Comments

@Paul-Etienne
Copy link

This is more a feature request than an issue per se.

Would it be possible to add a maven plugin to allow Protobuf generation for Swift?
This would be very helpful.

@thomasvl
Copy link
Collaborator

thomasvl commented Sep 3, 2021

Not knowing anything really about Maven, does it have to be provided by this project, or would it make sense for it to be an independent project?

@ktoso
Copy link
Member

ktoso commented Sep 4, 2021

Nothing has to be done here because the maven plugin allows for a custom protoc plugin to be used, in the compile-custom target: https://www.xolstice.org/protobuf-maven-plugin/compile-custom-mojo.html you'd set it up to target the swift protobuif binary and it should work just fine.

@ktoso
Copy link
Member

ktoso commented Sep 4, 2021

It could be nice to add a specific target for swift, as there exist for other languages ( https://www.xolstice.org/protobuf-maven-plugin/ ) but that would be done in the maven plugin, not here.

@thomasvl
Copy link
Collaborator

Based on @ktoso's comments, it sounds like we should go ahead and close this since it doesn't need to be something in this repo. Is that ok?

@Pushkarang
Copy link

@ktoso Do we always have to generate binary (either building it from source / homebrew) and use it? Is there a maven artifact published for swift-protobuf similar to https://mvnrepository.com/artifact/io.grpc/protoc-gen-grpc-java/1.60.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants