Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: module 'SwiftProtobuf' was not compiled with library evolution support; using it means binary compatibility for 'TestModule' can't be guaranteed #1198

Closed
djfitz opened this issue Nov 1, 2021 · 4 comments

Comments

@djfitz
Copy link

djfitz commented Nov 1, 2021

Adding Swift-protobuf to our Xcode project causes the following build warning to be produced:

warning: module 'SwiftProtobufPluginLibrary' was not compiled with library evolution support; using it means binary compatibility for 'TestModule' can't be guaranteed
import SwiftProtobufPluginLibrary
^
In the interest of reducing build warnings, I request that the following setting be made on the Protobuf Xcode project build settings:

BUILD_LIBRARY_FOR_DISTRIBUTION = YES;


Build Configuration

  • macOS 11.6 (20G165)
  • Xcode version 13.1 (13A1030d)
  • Swift 5.5
  • SwiftProtobuf 1.17.0
@Lukasa
Copy link
Contributor

Lukasa commented Nov 1, 2021

It may be worth examining #1101 for prior discussion of library evolution mode.

@tbkka
Copy link
Contributor

tbkka commented Nov 1, 2021

Purely out of curiosity, what are you using the "PluginLibrary" for? Most people only use the core "SwiftProtobuf" library and I'm interested in learning more about how people use the plugin library so we can do a better job evolving it in the future.

@djfitz
Copy link
Author

djfitz commented Nov 2, 2021

It may be worth examining #1101 for prior discussion of library evolution mode.

Thanks for the reply. I will follow up on the other issue.

@djfitz
Copy link
Author

djfitz commented Nov 2, 2021

Purely out of curiosity, what are you using the "PluginLibrary" for? Most people only use the core "SwiftProtobuf" library and I'm interested in learning more about how people use the plugin library so we can do a better job evolving it in the future.

Hello, thanks so much for your reply.

First off, I'm not the original developer who added protobuf to our app; I'm in charge of taking care of build warnings and these protobuf warnings are some of the last issues I haven't been able to clean up. So, I'm figuring out some of the protobuf issues after the fact.

After some more investigation, we apparently are just a regular client and the import of the SwiftProtobufPluginLibrary module was not needed. I changed to import SwiftProtobuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants