New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/integrations/pytest/test_namer.py fails if cloned to a different directory name #183

Open

JayBazuzi opened this issue Nov 4, 2024 · 3 comments

Contributor

JayBazuzi commented Nov 4, 2024 •

edited

Loading

To Reproduce:

git clone https://github.com/approvals/ApprovalTests.Python foo
cd foo
./run_tests.sh

Result:

test_received_filename fails

The text was updated successfully, but these errors were encountered:

Contributor

MichaelRWolf commented Nov 4, 2024

Yup. Fails for me, too.

Even after I s/python/python3/ in ./run_tests.sh.

Contributor Author

JayBazuzi commented Nov 4, 2024

The problem is here: https://github.com/approvals/ApprovalTests.Python/blob/main/tests/integrations/pytest/test_namer.py#L14 (and a few lines down) which hard-code the name of the directory.

Contributor

MichaelRWolf commented Nov 4, 2024

If it helps... git rev-parse --show-toplevel returns the absolute path of the project root, either

/Users/michael/repos/ApprovalTests.Python
or
/Users/michael/repos/foo

That could be used in various ways with dirname, basename to pass relative paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment