Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal must use server-side merge when updating manifests #520

Closed
bastjan opened this issue Mar 24, 2023 · 0 comments · Fixed by #521
Closed

Portal must use server-side merge when updating manifests #520

bastjan opened this issue Mar 24, 2023 · 0 comments · Fixed by #521
Labels
bug Something isn't working

Comments

@bastjan
Copy link
Contributor

bastjan commented Mar 24, 2023

Description

During the rollout of Billing Entities we noticed problems updating the Organizations through the portal. kubectl edit did not show the same issues.

The underlying issue was a combination of the forgotten idp adapter vshn/appuio-keycloak-adapter#44 and the portal not passing the .metadata.finalizers field.

While the immediate issue is fixed this problem will happen again in the future when portal and control api are out of sync.

The portal tells Kubernetes (with a PUT request) to override the live object with the version in the request. All fields not in the request are zeroed. Kubernetes does support server side merging which allows to override only fields contained in the request. The portal should start to tell kubernetes to only update fields the portal knows with a PATCH application/merge-patch+json request.

Also see vshn/appuio-keycloak-adapter#47.

Additional Context

No response

Logs

No response

Expected Behavior

PATCH ...
Content-Type: application/merge-patch+json

(or similar) is used by the portal

Steps To Reproduce

No response

@bastjan bastjan added the bug Something isn't working label Mar 24, 2023
@bastjan bastjan changed the title Portal must use server side merge when updating manifests Portal must use server-side merge when updating manifests Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant