You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the rollout of Billing Entities we noticed problems updating the Organizations through the portal. kubectl edit did not show the same issues.
The underlying issue was a combination of the forgotten idp adapter vshn/appuio-keycloak-adapter#44 and the portal not passing the .metadata.finalizers field.
While the immediate issue is fixed this problem will happen again in the future when portal and control api are out of sync.
The portal tells Kubernetes (with a PUT request) to override the live object with the version in the request. All fields not in the request are zeroed. Kubernetes does support server side merging which allows to override only fields contained in the request. The portal should start to tell kubernetes to only update fields the portal knows with a PATCH application/merge-patch+json request.
bastjan
changed the title
Portal must use server side merge when updating manifests
Portal must use server-side merge when updating manifests
Mar 24, 2023
Description
During the rollout of Billing Entities we noticed problems updating the Organizations through the portal.
kubectl edit
did not show the same issues.The underlying issue was a combination of the forgotten idp adapter vshn/appuio-keycloak-adapter#44 and the portal not passing the
.metadata.finalizers
field.While the immediate issue is fixed this problem will happen again in the future when portal and control api are out of sync.
The portal tells Kubernetes (with a
PUT
request) to override the live object with the version in the request. All fields not in the request are zeroed. Kubernetes does support server side merging which allows to override only fields contained in the request. The portal should start to tell kubernetes to only update fields the portal knows with aPATCH application/merge-patch+json
request.Also see vshn/appuio-keycloak-adapter#47.
Additional Context
No response
Logs
No response
Expected Behavior
(or similar) is used by the portal
Steps To Reproduce
No response
The text was updated successfully, but these errors were encountered: