Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Resource Count Delection Skipping #1194

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

gambol99
Copy link
Member

When then configuration has not provisioned any ressources, we can skip the deletion job

When then configuration has not provisioned any ressources, we can skip the deletion job
@gambol99
Copy link
Member Author

Related to #1187

@gambol99
Copy link
Member Author

Fixed up as suggested in fb63ce6 @KashifSaadat

@gambol99 gambol99 requested a review from KashifSaadat January 19, 2024 09:37
Copy link
Member

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@gambol99 gambol99 merged commit 2f5bd63 into develop Jan 19, 2024
8 checks passed
@gambol99 gambol99 deleted the feat_zero_block branch January 19, 2024 14:11
gambol99 added a commit that referenced this pull request Jan 23, 2024
* [FEATURE] - Resource Count Delection Skipping

When then configuration has not provisioned any ressources, we can skip the deletion job

* fix: adding the suggested amendments

* chore: adding a fake dummy module, that does nothing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run a terraform destroy if there are no resources to clean up
2 participants