From 8dfd101dbaf8ae0447a05a937737c06cef0304b0 Mon Sep 17 00:00:00 2001 From: teenager-ETH Date: Sat, 1 Feb 2025 23:48:13 +0100 Subject: [PATCH 1/4] Typos in the CHANGELOG.md --- api/doc/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/doc/CHANGELOG.md b/api/doc/CHANGELOG.md index 63ad6763a3232..49820826b35d8 100644 --- a/api/doc/CHANGELOG.md +++ b/api/doc/CHANGELOG.md @@ -110,8 +110,8 @@ This section is dedicated to the finer details of the API change, but we include - Epoch is returned as a U64 (the string wrapper), not a u64. The v0 API received this change too, as the previous behavior was inconsistent and potentially incorrect. - `/transactions/simulate` returns a `UserTransaction` now, not just a `Transaction`. The user can only ever submit a user transaction to this endpoint, so it can only ever return a user transaction. - All docs in the spec that incorrectly used a 16 byte address have been updated. -- MoveTypes are now returned as structured structs instead of strings. To deal with some types that we don't have proper parsing for, e.g. generic type params, a new “unparseable” variant has been added. This ensures the response from the API can actually be deserialized. - - MoveValue has received the same treatment, minus the unparseable stuff. +- MoveTypes are now returned as structured structs instead of strings. To deal with some types that we don't have proper parsing for, e.g. generic type params, a new “unparsable” variant has been added. This ensures the response from the API can actually be deserialized. + - MoveValue has received the same treatment, minus the unparsable stuff. - Some snake casing is different, e.g. ed25519 became ed_25519 (proper snake casing). - U64 and U128 have been used throughout every endpoint. There were a couple of places in v0 where we should've been using it but weren't, e.g. paging params. - The `v1` API runs on a separate port (where the OS selects a free port) behind a reverse proxy running within the node. This works fine with our source and docker based deployments. This is only temporary while we host both APIs. From 658aa79ef04b2cdcedaf2ddb44c488243e503b18 Mon Sep 17 00:00:00 2001 From: teenager-ETH Date: Sat, 1 Feb 2025 23:48:38 +0100 Subject: [PATCH 2/4] Typo in the lib.rs --- aptos-move/aptos-vm-logging/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aptos-move/aptos-vm-logging/src/lib.rs b/aptos-move/aptos-vm-logging/src/lib.rs index b757e578a02de..336f1160b7a3c 100644 --- a/aptos-move/aptos-vm-logging/src/lib.rs +++ b/aptos-move/aptos-vm-logging/src/lib.rs @@ -140,7 +140,7 @@ pub fn flush_speculative_logs(num_to_flush: usize) { } } -/// Clear speculative logs recorded for a specific transction, useful when transaction +/// Clear speculative logs recorded for a specific transaction, useful when transaction /// execution fails validation and aborts - setting stage for the re-execution. pub fn clear_speculative_txn_logs(txn_idx: usize) { if speculation_disabled() { From 524475ac6277f0239b4f80d1bdca2df1464e6795 Mon Sep 17 00:00:00 2001 From: teenager-ETH Date: Sat, 1 Feb 2025 23:49:20 +0100 Subject: [PATCH 3/4] Typo in the mod.rs --- aptos-move/aptos-vm/src/block_executor/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aptos-move/aptos-vm/src/block_executor/mod.rs b/aptos-move/aptos-vm/src/block_executor/mod.rs index a771cbe694b3f..946d6770bb6d7 100644 --- a/aptos-move/aptos-vm/src/block_executor/mod.rs +++ b/aptos-move/aptos-vm/src/block_executor/mod.rs @@ -94,7 +94,7 @@ impl AptosTransactionOutput { .take() .expect("Output must be set") .into_transaction_output() - .expect("Transaction output is not alerady materialized"), + .expect("Transaction output is not already materialized"), } } } From 067cd62cb8e2e865224ff2922ab8e33fafc7503f Mon Sep 17 00:00:00 2001 From: teenager-ETH Date: Sat, 1 Feb 2025 23:49:57 +0100 Subject: [PATCH 4/4] Fix typo in the token.md --- aptos-move/framework/aptos-token/doc/token.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aptos-move/framework/aptos-token/doc/token.md b/aptos-move/framework/aptos-token/doc/token.md index e14e3e7d1161c..0ae377ee1bd08 100644 --- a/aptos-move/framework/aptos-token/doc/token.md +++ b/aptos-move/framework/aptos-token/doc/token.md @@ -3045,7 +3045,7 @@ Mutate the token_properties of one token. assert!(table::contains(all_token_data, token_id.token_data_id), error::not_found(ETOKEN_DATA_NOT_PUBLISHED)); let token_data = table::borrow_mut(all_token_data, token_id.token_data_id); - // if default property is mutatable, token property is alwasy mutable + // if default property is mutatable, token property is always mutable // we only need to check TOKEN_PROPERTY_MUTABLE when default property is immutable if (!token_data.mutability_config.properties) { assert!(