Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Support for execution on Windows #125

Open
drtimf opened this issue Jul 6, 2020 · 3 comments
Open

Support for execution on Windows #125

drtimf opened this issue Jul 6, 2020 · 3 comments

Comments

@drtimf
Copy link

drtimf commented Jul 6, 2020

Since most of the implementation of this is platform independent (pulling images from repositories and extracting them), it should be possible to execute this on Windows. Currently the main problem is that paths being fed into the analyzers are in Windows form (i.e. backslash), while the analyzers are looking for key files using UNIX path separators.

Need to either have the analyzers look for paths using the native separator, or have the paths fed to the analyzers consistently use UNIX path separators.

I suppose the issue could be in the walker/tar.go where it is using a filepath.Clean() and filepath.Join() causing the native file separator to be used.

@avats-dev
Copy link

Can I work on this, is this still relevant? Also, can anyone guide me a bit in resolving this? Thanks.

@simar7
Copy link
Member

simar7 commented Oct 10, 2020

Since most of the implementation of this is platform independent (pulling images from repositories and extracting them), it should be possible to execute this on Windows. Currently the main problem is that paths being fed into the analyzers are in Windows form (i.e. backslash), while the analyzers are looking for key files using UNIX path separators.

Do you have an example of what you saw here?

@avats-dev
Copy link

@simar7 I use ubuntu, but I used to use windows previously.

So, what I understood from the issue is that we can implement this in windows too, but we just have a problem that a file path such as file1/file2/.. would be like file1\file2\.. in windows. And, that's why I asked for help in how to implement this.

Is this clear?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants