Added empty actual value and expected value and non-empty flagName test #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arjunkhunti-cds
changed the title
arjunkhunti-cds
changed the title
mozillazg
reviewed
Nov 5, 2023
mozillazg
requested changes
Nov 7, 2023
| @@ -143,7 +143,11 @@ func (t flagTestItem) findValue(s string) (match bool, value string, err error) | |||
| if strings.HasPrefix(t.Flag, "--") { | |||
| value = "true" | |||
| } else { | |||
| value = vals[1] | |||
| if t.Compare.Op == "eq" && !strings.Contains(t.Flag, ":") { | |||
There was a problem hiding this comment.
IMHO, adding a workaround code (!strings.Contains(t.Flag, ":")) is not a good idea.
How about adding a new op like isempty instead of changing the eq op for your cases to support empty value?
There was a problem hiding this comment.
I'm not familiar with the process of adding a new operation, and I'm thinking about closing this pull request. I'll communicate this process in the corresponding issue to encourage others to contribute instead.
|
As the suggested approach is different as implemented in this PR. Hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kube-bench checks fail when the
flagValandcompareValueare empty strings andflagNameis given. To resolve this, I have updated the code whereflagNameis assigned to thecompareValand added a test for the same.Expected Outcome
Actual Outcome