PNPM - False positives for types packages. #6749

cristobal · 2024-05-22T08:48:42Z

cristobal
May 22, 2024

IDs

CVE-2021-44906, CVE-2022-0235, CVE-2022-46175

Description

The mentioned IDs above are reported as vulnerabilities for @types/package-name, when the pnpm package manager is used, this does not happen when default npm package manager is used.

My suspicion is how the pnpm-lock.yaml is parsed for vulnerabilities rather than seeing the complete @types/package-name it sees them as package-name instead, i have a repo here that highlights this. The repo has the following @types packages installed via pnpm,:

Running trivy fs scan yields the following false positive errors:

Reproduction Steps

1. Check out the repo github.com/cristobal/trivy-false-positive-pnpm-types-packages
2. Run `trivy fs .`, from the root of repo.
3. Should yield false positive error report.

Target

Filesystem

Scanner

Vulnerability

Target OS

Mac OS, Ubuntu, Alpine

Debug Output

{
  "SchemaVersion": 2,
  "CreatedAt": "2024-05-22T10:48:23.888467+02:00",
  "ArtifactName": ".",
  "ArtifactType": "filesystem",
  "Metadata": {
    "ImageConfig": {
      "architecture": "",
      "created": "0001-01-01T00:00:00Z",
      "os": "",
      "rootfs": {
        "type": "",
        "diff_ids": null
      },
      "config": {}
    }
  },
  "Results": [
    {
      "Target": "pnpm-lock.yaml",
      "Class": "lang-pkgs",
      "Type": "pnpm",
      "Vulnerabilities": [
        {
          "VulnerabilityID": "CVE-2022-46175",
          "PkgID": "[email protected]",
          "PkgName": "json5",
          "PkgIdentifier": {
            "PURL": "pkg:npm/[email protected]",
            "UID": "8e81791cf36ee29c"
          },
          "InstalledVersion": "0.0.29",
          "FixedVersion": "2.2.2, 1.0.2",
          "Status": "fixed",
          "Layer": {},
          "SeveritySource": "ghsa",
          "PrimaryURL": "https://avd.aquasec.com/nvd/cve-2022-46175",
          "DataSource": {
            "ID": "ghsa",
            "Name": "GitHub Security Advisory npm",
            "URL": "https://github.com/advisories?query=type%3Areviewed+ecosystem%3Anpm"
          },
          "Title": "json5: Prototype Pollution in JSON5 via Parse Method",
          "Description": "JSON5 is an extension to the popular JSON file format that aims to be easier to write and maintain by hand (e.g. for config files). The `parse` method of the JSON5 library before and including versions 1.0.1 and 2.2.1 does not restrict parsing of keys named `__proto__`, allowing specially crafted strings to pollute the prototype of the resulting object. This vulnerability pollutes the prototype of the object returned by `JSON5.parse` and not the global Object prototype, which is the commonly understood definition of Prototype Pollution. However, polluting the prototype of a single object can have significant security impact for an application if the object is later used in trusted operations. This vulnerability could allow an attacker to set arbitrary and unexpected keys on the object returned from `JSON5.parse`. The actual impact will depend on how applications utilize the returned object and how they filter unwanted keys, but could include denial of service, cross-site scripting, elevation of privilege, and in extreme cases, remote code execution. `JSON5.parse` should restrict parsing of `__proto__` keys when parsing JSON strings to objects. As a point of reference, the `JSON.parse` method included in JavaScript ignores `__proto__` keys. Simply changing `JSON5.parse` to `JSON.parse` in the examples above mitigates this vulnerability. This vulnerability is patched in json5 versions 1.0.2, 2.2.2, and later.",
          "Severity": "HIGH",
          "CweIDs": [
            "CWE-1321"
          ],
          "VendorSeverity": {
            "ghsa": 3,
            "nvd": 3,
            "redhat": 2,
            "ubuntu": 2
          },
          "CVSS": {
            "ghsa": {
              "V3Vector": "CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:H/I:L/A:H",
              "V3Score": 7.1
            },
            "nvd": {
              "V3Vector": "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H",
              "V3Score": 8.8
            },
            "redhat": {
              "V3Vector": "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H",
              "V3Score": 8.8
            }
          },
          "References": [
            "https://access.redhat.com/security/cve/CVE-2022-46175",
            "https://github.com/json5/json5",
            "https://github.com/json5/json5/commit/62a65408408d40aeea14c7869ed327acead12972",
            "https://github.com/json5/json5/commit/7774c1097993bc3ce9f0ac4b722a32bf7d6871c8",
            "https://github.com/json5/json5/issues/199",
            "https://github.com/json5/json5/issues/295",
            "https://github.com/json5/json5/pull/298",
            "https://github.com/json5/json5/security/advisories/GHSA-9c47-m6qq-7p4h",
            "https://lists.debian.org/debian-lts-announce/2023/11/msg00021.html",
            "https://lists.fedoraproject.org/archives/list/package-announce%40lists.fedoraproject.org/message/3S26TLPLVFAJTUN3VIXFDEBEXDYO22CE/",
            "https://lists.fedoraproject.org/archives/list/[email protected]/message/3S26TLPLVFAJTUN3VIXFDEBEXDYO22CE",
            "https://nvd.nist.gov/vuln/detail/CVE-2022-46175",
            "https://ubuntu.com/security/notices/USN-6758-1",
            "https://www.cve.org/CVERecord?id=CVE-2022-46175"
          ],
          "PublishedDate": "2022-12-24T04:15:08.787Z",
          "LastModifiedDate": "2023-11-26T01:15:07.177Z"
        },
        {
          "VulnerabilityID": "CVE-2021-44906",
          "PkgID": "[email protected]",
          "PkgName": "minimist",
          "PkgIdentifier": {
            "PURL": "pkg:npm/[email protected]",
            "UID": "c5fa44ad8926390f"
          },
          "InstalledVersion": "1.2.2",
          "FixedVersion": "1.2.6, 0.2.4",
          "Status": "fixed",
          "Layer": {},
          "SeveritySource": "ghsa",
          "PrimaryURL": "https://avd.aquasec.com/nvd/cve-2021-44906",
          "DataSource": {
            "ID": "ghsa",
            "Name": "GitHub Security Advisory npm",
            "URL": "https://github.com/advisories?query=type%3Areviewed+ecosystem%3Anpm"
          },
          "Title": "minimist: prototype pollution",
          "Description": "Minimist \u003c=1.2.5 is vulnerable to Prototype Pollution via file index.js, function setKey() (lines 69-95).",
          "Severity": "CRITICAL",
          "CweIDs": [
            "CWE-1321"
          ],
          "VendorSeverity": {
            "alma": 2,
            "ghsa": 4,
            "nvd": 4,
            "oracle-oval": 2,
            "redhat": 2,
            "rocky": 2
          },
          "CVSS": {
            "ghsa": {
              "V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H",
              "V3Score": 9.8
            },
            "nvd": {
              "V2Vector": "AV:N/AC:L/Au:N/C:P/I:P/A:P",
              "V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H",
              "V2Score": 7.5,
              "V3Score": 9.8
            },
            "redhat": {
              "V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H",
              "V3Score": 9.8
            }
          },
          "References": [
            "https://access.redhat.com/errata/RHSA-2023:0321",
            "https://access.redhat.com/security/cve/CVE-2021-44906",
            "https://bugzilla.redhat.com/2066009",
            "https://bugzilla.redhat.com/2130518",
            "https://bugzilla.redhat.com/2134609",
            "https://bugzilla.redhat.com/2140911",
            "https://bugzilla.redhat.com/show_bug.cgi?id=2066009",
            "https://bugzilla.redhat.com/show_bug.cgi?id=2130518",
            "https://bugzilla.redhat.com/show_bug.cgi?id=2134609",
            "https://bugzilla.redhat.com/show_bug.cgi?id=2140911",
            "https://bugzilla.redhat.com/show_bug.cgi?id=2142808",
            "https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-44906",
            "https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3517",
            "https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-35256",
            "https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-43548",
            "https://errata.almalinux.org/9/ALSA-2023-0321.html",
            "https://errata.rockylinux.org/RLSA-2023:0321",
            "https://github.com/Marynk/JavaScript-vulnerability-detection/blob/main/minimist%20PoC.zip",
            "https://github.com/advisories/GHSA-xvch-5gv4-984h",
            "https://github.com/minimistjs/minimist/commit/34e20b8461118608703d6485326abbb8e35e1703",
            "https://github.com/minimistjs/minimist/commit/bc8ecee43875261f4f17eb20b1243d3ed15e70eb",
            "https://github.com/minimistjs/minimist/commit/c2b981977fa834b223b408cfb860f933c9811e4d",
            "https://github.com/minimistjs/minimist/commit/ef9153fc52b6cea0744b2239921c5dcae4697f11",
            "https://github.com/minimistjs/minimist/commits/v0.2.4",
            "https://github.com/minimistjs/minimist/issues/11",
            "https://github.com/minimistjs/minimist/pull/24",
            "https://github.com/substack/minimist",
            "https://github.com/substack/minimist/blob/master/index.js#L69",
            "https://github.com/substack/minimist/issues/164",
            "https://linux.oracle.com/cve/CVE-2021-44906.html",
            "https://linux.oracle.com/errata/ELSA-2023-0321.html",
            "https://nvd.nist.gov/vuln/detail/CVE-2021-44906",
            "https://snyk.io/vuln/SNYK-JS-MINIMIST-559764",
            "https://stackoverflow.com/questions/8588563/adding-custom-properties-to-a-function/20278068#20278068",
            "https://www.cve.org/CVERecord?id=CVE-2021-44906"
          ],
          "PublishedDate": "2022-03-17T16:15:07.51Z",
          "LastModifiedDate": "2022-04-12T16:52:21.56Z"
        },
        {
          "VulnerabilityID": "CVE-2020-7598",
          "PkgID": "[email protected]",
          "PkgName": "minimist",
          "PkgIdentifier": {
            "PURL": "pkg:npm/[email protected]",
            "UID": "c5fa44ad8926390f"
          },
          "InstalledVersion": "1.2.2",
          "FixedVersion": "0.2.1, 1.2.3",
          "Status": "fixed",
          "Layer": {},
          "SeveritySource": "ghsa",
          "PrimaryURL": "https://avd.aquasec.com/nvd/cve-2020-7598",
          "DataSource": {
            "ID": "ghsa",
            "Name": "GitHub Security Advisory npm",
            "URL": "https://github.com/advisories?query=type%3Areviewed+ecosystem%3Anpm"
          },
          "Title": "nodejs-minimist: prototype pollution allows adding or modifying properties of Object.prototype using a constructor or __proto__ payload",
          "Description": "minimist before 1.2.2 could be tricked into adding or modifying properties of Object.prototype using a \"constructor\" or \"__proto__\" payload.",
          "Severity": "MEDIUM",
          "CweIDs": [
            "CWE-1321"
          ],
          "VendorSeverity": {
            "alma": 3,
            "ghsa": 2,
            "nvd": 2,
            "oracle-oval": 3,
            "redhat": 2
          },
          "CVSS": {
            "ghsa": {
              "V3Vector": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:L/A:L",
              "V3Score": 5.6
            },
            "nvd": {
              "V2Vector": "AV:N/AC:M/Au:N/C:P/I:P/A:P",
              "V3Vector": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:L/A:L",
              "V2Score": 6.8,
              "V3Score": 5.6
            },
            "redhat": {
              "V3Vector": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:L/A:L",
              "V3Score": 5.6
            }
          },
          "References": [
            "http://lists.opensuse.org/opensuse-security-announce/2020-06/msg00024.html",
            "https://access.redhat.com/security/cve/CVE-2020-7598",
            "https://errata.almalinux.org/8/ALSA-2020-2852.html",
            "https://github.com/minimistjs/minimist/commit/10bd4cdf49d9686d48214be9d579a9cdfda37c68",
            "https://github.com/minimistjs/minimist/commit/38a4d1caead72ef99e824bb420a2528eec03d9ab",
            "https://github.com/minimistjs/minimist/commit/4cf1354839cb972e38496d35e12f806eea92c11f#diff-a1e0ee62c91705696ddb71aa30ad4f95",
            "https://github.com/minimistjs/minimist/commit/63e7ed05aa4b1889ec2f3b196426db4500cbda94",
            "https://github.com/substack/minimist",
            "https://linux.oracle.com/cve/CVE-2020-7598.html",
            "https://linux.oracle.com/errata/ELSA-2020-2852.html",
            "https://nvd.nist.gov/vuln/detail/CVE-2020-7598",
            "https://snyk.io/vuln/SNYK-JS-MINIMIST-559764",
            "https://www.cve.org/CVERecord?id=CVE-2020-7598",
            "https://www.npmjs.com/advisories/1179"
          ],
          "PublishedDate": "2020-03-11T23:15:11.917Z",
          "LastModifiedDate": "2022-04-22T19:02:41.177Z"
        },
        {
          "VulnerabilityID": "CVE-2022-0235",
          "PkgID": "[email protected]",
          "PkgName": "node-fetch",
          "PkgIdentifier": {
            "PURL": "pkg:npm/[email protected]",
            "UID": "a9d2fb003460eb7"
          },
          "InstalledVersion": "2.6.4",
          "FixedVersion": "3.1.1, 2.6.7",
          "Status": "fixed",
          "Layer": {},
          "SeveritySource": "ghsa",
          "PrimaryURL": "https://avd.aquasec.com/nvd/cve-2022-0235",
          "DataSource": {
            "ID": "ghsa",
            "Name": "GitHub Security Advisory npm",
            "URL": "https://github.com/advisories?query=type%3Areviewed+ecosystem%3Anpm"
          },
          "Title": "node-fetch: exposure of sensitive information to an unauthorized actor",
          "Description": "node-fetch is vulnerable to Exposure of Sensitive Information to an Unauthorized Actor",
          "Severity": "HIGH",
          "CweIDs": [
            "CWE-200",
            "CWE-601"
          ],
          "VendorSeverity": {
            "alma": 2,
            "ghsa": 3,
            "nvd": 2,
            "oracle-oval": 2,
            "redhat": 2,
            "ubuntu": 2
          },
          "CVSS": {
            "ghsa": {
              "V3Vector": "CVSS:3.0/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H",
              "V3Score": 8.8
            },
            "nvd": {
              "V2Vector": "AV:N/AC:M/Au:N/C:P/I:P/A:N",
              "V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N",
              "V2Score": 5.8,
              "V3Score": 6.1
            },
            "redhat": {
              "V3Vector": "CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:C/C:H/I:N/A:N",
              "V3Score": 6.1
            }
          },
          "References": [
            "https://access.redhat.com/errata/RHSA-2023:0050",
            "https://access.redhat.com/security/cve/CVE-2022-0235",
            "https://bugzilla.redhat.com/2044591",
            "https://bugzilla.redhat.com/2066009",
            "https://bugzilla.redhat.com/2134609",
            "https://bugzilla.redhat.com/2140911",
            "https://bugzilla.redhat.com/2150323",
            "https://cert-portal.siemens.com/productcert/pdf/ssa-637483.pdf",
            "https://errata.almalinux.org/8/ALSA-2023-0050.html",
            "https://github.com/node-fetch/node-fetch",
            "https://github.com/node-fetch/node-fetch/commit/1ef4b560a17e644a02a3bfdea7631ffeee578b35",
            "https://github.com/node-fetch/node-fetch/commit/36e47e8a6406185921e4985dcbeff140d73eaa10",
            "https://github.com/node-fetch/node-fetch/commit/5c32f002fdd65b1c6a8f1e3620210813d45c7e60",
            "https://github.com/node-fetch/node-fetch/pull/1449/commits/5c32f002fdd65b1c6a8f1e3620210813d45c7e60",
            "https://github.com/node-fetch/node-fetch/pull/1453",
            "https://huntr.dev/bounties/d26ab655-38d6-48b3-be15-f9ad6b6ae6f7",
            "https://huntr.dev/bounties/d26ab655-38d6-48b3-be15-f9ad6b6ae6f7/",
            "https://linux.oracle.com/cve/CVE-2022-0235.html",
            "https://linux.oracle.com/errata/ELSA-2023-0050.html",
            "https://lists.debian.org/debian-lts-announce/2022/12/msg00007.html",
            "https://nvd.nist.gov/vuln/detail/CVE-2022-0235",
            "https://ubuntu.com/security/notices/USN-6158-1",
            "https://www.cve.org/CVERecord?id=CVE-2022-0235"
          ],
          "PublishedDate": "2022-01-16T17:15:07.87Z",
          "LastModifiedDate": "2023-02-03T19:16:07.09Z"
        }
      ]
    }
  ]
}

Version

Version: 0.51.2
Vulnerability DB:
  Version: 2
  UpdatedAt: 2024-05-22 06:10:58.694031857 +0000 UTC
  NextUpdate: 2024-05-22 12:10:58.694031466 +0000 UTC
  DownloadedAt: 2024-05-22 08:24:24.103208 +0000 UTC
Check Bundle:
  Digest: sha256:6d0771effa53c6cf8130861fc3ac28f5515c35a028edb4bb1e67261b9218c80e
  DownloadedAt: 2024-05-16 11:37:08.819428 +0000 UTC

Checklist

Read the documentation regarding wrong detection
Ran Trivy with -f json that shows data sources and confirmed that the security advisory in data sources was correct

DmitriyLewen · 2024-05-22T09:57:29Z

DmitriyLewen
May 22, 2024
Maintainer

duplicate of #6509

2 replies

cristobal May 22, 2024
Author

Thanks for the info @DmitriyLewen, still it's not clear from #6509 and #6503 that this is a side effect. Should the label «False Detection» be added to #6509 ?

DmitriyLewen May 22, 2024
Maintainer

Trivy v0.51.2 doesn't support lockfile v9 (see https://aquasecurity.github.io/trivy/v0.51/docs/coverage/language/nodejs/#pnpm).

So i think False Detection label is incorrect for this case.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PNPM - False positives for types packages. #6749

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment 2 replies

{{title}}

{{title}}

{{title}}

Select a reply

PNPM - False positives for types packages. #6749

cristobal May 22, 2024

IDs

Description

Reproduction Steps

Target

Scanner

Target OS

Debug Output

Version

Checklist

Replies: 1 comment · 2 replies

DmitriyLewen May 22, 2024 Maintainer

cristobal May 22, 2024 Author

DmitriyLewen May 22, 2024 Maintainer

cristobal
May 22, 2024

Replies: 1 comment 2 replies

DmitriyLewen
May 22, 2024
Maintainer

cristobal May 22, 2024
Author

DmitriyLewen May 22, 2024
Maintainer