Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finance, Agent: add thousands separators to token balances module #1065

Closed
2 tasks done
izqui opened this issue Jan 10, 2020 · 2 comments
Closed
2 tasks done

Finance, Agent: add thousands separators to token balances module #1065

izqui opened this issue Jan 10, 2020 · 2 comments
Labels
app: agent app: finance component: frontend good first issue

Comments

@izqui
Copy link
Contributor

izqui commented Jan 10, 2020 •
edited by sohkai
Loading

Quite hard to read at a glance otherwise:

Screen Shot 2020-01-10 at 5 06 08 PM

Implementation status
This was referenced Feb 13, 2020
Closed
Closed
@Evalir Evalir self-assigned this Apr 4, 2020
@Evalir
Copy link
Contributor

Evalir commented Apr 6, 2020

This seems to have been fixed already. :)

Finance (on network dao):
Screen Shot 2020-04-06 at 5.25.33 PM.png

@sohkai
Copy link
Contributor

sohkai commented Apr 7, 2020

I think that might've been off of the PR fixing this?

It is currently not fixed on production for me:
Screen Shot 2020-04-07 at 2.19.58 PM.png

This will require the API from https://github.com/aragon/aragon-ui/pull/728 :).

@ECWireless ECWireless mentioned this issue May 13, 2020
Closed
@rperez89 rperez89 mentioned this issue May 14, 2020
Merged
@ECWireless ECWireless mentioned this issue May 18, 2020
Merged
4 tasks
@bpierre bpierre changed the title Finance: add thousands separators to token balances module Finance, Agent: add thousands separators to token balances module Jun 10, 2020
@sohkai sohkai closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: agent app: finance component: frontend good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finance: Add Thousands Separator Util from UI ECWireless/aragon-apps
4 participants
@bpierre @izqui @sohkai @Evalir