Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash fallback will erroneously redirect user if app is running under subfolder #4

Open
hems opened this issue Apr 28, 2014 · 3 comments
Labels

Comments

@hems
Copy link

hems commented Apr 28, 2014

when my application runs inside of a folder ( for instance domain.com/my_project ), and not on the "root path" of my domain/subdomain i get instantly redirected to domain.com#/my_project

i managed to workaround that by adding base_path property and doing a couple of changes on my hash.coffee.

you can have a look here: https://github.com/hems/ways-browser/blob/hash-hack/src/hash.coffee

@arboleya
Copy link
Owner

The fallback which must account for sub/domains and protocols in the current url. Its not related to the base_path as this last account for folders.

@arboleya arboleya added the bug label Apr 28, 2014
@arboleya
Copy link
Owner

Could you send a test for it?

@arboleya
Copy link
Owner

Just keeping things apart.
arboleya/ways#4

@hems hems changed the title running router under a "base_path" will fail when falling back to "hash" hash fallback will erroneously redirect user if app is running under subfolder Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants