-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filename method of Package should return Option<&str> #18
Comments
Good find. |
There's probably going to be a couple more of these. Paru is effected and I don't believe it calls that function. |
Aura doesn't as of yet either. |
"Fixed" with 6681b33 Will hold off on a proper fix until I find all the functions that may return null and as I don't want to push a v3 just yet. |
This c413be4#diff-6d974fec9cd167345df12f3e136a7be85c0f1bcfe60805940d14e881dda30b6c is my fix for now. Basically the same concept as my last comment but easier to strip out when it comes time for v3. Also I believe the functions mentioned in #19 are the only functions that should be an option so I think this is all solved. |
Local packages don't have a "filename" field. Therefore, calling filename() results in a panic.
Minimal reproducible example:
Output:
The text was updated successfully, but these errors were encountered: