-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic validation errors when selecting mirror region on master #3081
Comments
@correctmost I couldn't reproduce the recursion part, but this PR #3104 might fix the problem as it will return on an empty mirror option list. |
Hmm, I was still able to reproduce the empty regions list and the I will try to get more debugging info. |
Would you know if your list is loaded from remote or local? Could you try running it with |
Here are two recent install logs from the PR ISO:
|
Okay let me try to debug it |
@correctmost would you be able to share your local |
Here's the mirror list from the VM I'm testing with:
|
Ahh yeah there's no country on the top so the region name is empty, the parser assumes
and then uses COUNTRY as the region name in the selection menu... maybe just calling it "Local" as a default should work |
Related discussion: #3013 |
@correctmost pushed an update to the PR that should fix the parsing now, also addressed the bug mentioned in #3013 |
Here are my findings after retesting:
|
I assume point 2 will be fixed by #3079 ? |
Hmm, my change from #3079 didn't fix the issue. This change makes all of the regions appear again, though: diff --git a/archinstall/lib/models/mirrors.py b/archinstall/lib/models/mirrors.py
index f899bc5e..2205b10f 100644
--- a/archinstall/lib/models/mirrors.py
+++ b/archinstall/lib/models/mirrors.py
@@ -29,7 +29,7 @@ class MirrorStatusEntryV3(BaseModel):
duration_avg: float | None = None
duration_stddev: float | None = None
completion_pct: float | None = None
- score: int | None = None
+ score: float | None = None
_latency: float | None = None
_speed: float | None = None
_hostname: str | None = None It seems like the ideal fix is to indicate that the incoming JSON has float data and the validated data has int data. I don't know the best way to accomplish that with Pydantic. |
Steps to reproduce
archinstall
from masterRecursionError
Logs
Bisection
Commit 1d278f8 seems to have introduced the validation errors. (I cannot reproduce the errors with the previous commit, 8f2bf2b.)
The text was updated successfully, but these errors were encountered: