Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nom 3 dependency (replace edid) #9

Open
Bogpan opened this issue Jun 3, 2023 · 2 comments
Open

Remove nom 3 dependency (replace edid) #9

Bogpan opened this issue Jun 3, 2023 · 2 comments
Assignees
Milestone

Comments

@Bogpan
Copy link

Bogpan commented Jun 3, 2023

Hi, when build my app that depends on ddc-hi I get this error message: warning: the following packages contain code that will be rejected by a future version of Rust: nom v3.2.1. The crates that seem to be relying on nom v3.2.1 are mccs (including mccs-caps and mccs-db) and edid. I tried looking into cargo's patch feature but the outdated crate seems to be in several places and I'm not sure I could update everything and have it all work, Cargo.lock is there for a reason.

@arcnmx
Copy link
Owner

arcnmx commented Jun 4, 2023

updating to mccs 0.2 is happening in the v0.5.x branch - unfortunately the work has been stalled for the last while but I'm hoping to be able to get back to it soon.

edid is an abandoned crate so there isn't a clear update path, but edid_rs might be an alternative option (though it also doesn't seem to be maintained)

@arcnmx arcnmx self-assigned this Jun 4, 2023
@arcnmx arcnmx added this to the v0.5.0 milestone Jun 4, 2023
@Bogpan
Copy link
Author

Bogpan commented Jun 10, 2023

Alright, thanks for the info. Maybe one could update the dependency of edid and just leave it at that at some point, for now that's fine I guess

@arcnmx arcnmx changed the title Outdated dependencies will not be supported in future Rust versions Remove nom 3 dependency Jun 13, 2023
@arcnmx arcnmx changed the title Remove nom 3 dependency Remove nom 3 dependency (replace edid) Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants