Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add env var test component #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stijnmoreels
Copy link
Member

Adds a TemporaryEnvironmentVariable test fixture to the core library. This helps with local testing when the test host spins up an application, or when authentication mechnisms need them (like managed identity).

Closes #166

@stijnmoreels stijnmoreels requested a review from a team as a code owner January 17, 2025 06:46
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for arcus-testing ready!

Name Link
🔨 Latest commit 901e146
🔍 Latest deploy log https://app.netlify.com/sites/arcus-testing/deploys/6789fcbd6229cd00087bb114
😎 Deploy Preview https://deploy-preview-253--arcus-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TemporaryEnvironmentVariable.Create("AZURE_TENANT_ID", servicePrincipal.TenantId),
TemporaryEnvironmentVariable.Create("AZURE_CLIENT_ID", servicePrincipal.ClientId),
TemporaryEnvironmentVariable.Create("AZURE_CLIENT_SECRET", servicePrincipal.ClientSecret)
TemporaryEnvironmentVariable.SetSecretIfNotExists("AZURE_TENANT_ID", servicePrincipal.TenantId, logger),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Eat your own 🐶 food', like they say. 😉

@arcus-automation
Copy link
Collaborator

🧪 Code coverage summary

Metric Value
Line coverage 🟢 92.3%
Branch coverage 🟢 81%

Great job! 😎 Your code coverage is higher than my caffeine levels! ☕

@stijnmoreels stijnmoreels added feature All issues related to new features area:core All issues related to al types of testing. labels Feb 4, 2025
@stijnmoreels stijnmoreels changed the title feat: add env var test component feat(core): add env var test component Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core All issues related to al types of testing. feature All issues related to new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add TemporaryEnvironmentVariable test fixture (to be used in a managed identity connection, for example)
2 participants