Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ Remove Serilog dependencies in logging packages #212

Open
3 of 5 tasks
stijnmoreels opened this issue Nov 1, 2024 · 0 comments
Open
3 of 5 tasks

🗑️ Remove Serilog dependencies in logging packages #212

stijnmoreels opened this issue Nov 1, 2024 · 0 comments
Labels
area:logging All issues related to test logging. dependencies Pull requests that update a dependency file good first issue Good for newcomers
Milestone

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Nov 1, 2024

Is your feature request related to a problem? Please describe.
In the past, when the Testing.Logging package was mostly internally used, we had introduced a Serilog variant to test out things in and test transactional correlation. But since this is now more publicly used, it does not seem right to force Serilog dependencies in these logging packages.

Describe the solution you'd like
Deprecate the Serilog references in the Logging.* packages.

Describe alternatives you've considered
None seems approporiate. We should strive towards minimal dependencies, and if people want to have custom test logging, they can still do this by building on top of our `Il

Additional context
The dependency is a transient one in the Logging.Core package.

💡 It would also be best that we stop releasing this package separately and guide people towards the test framework-specific ones.

Action plan

@stijnmoreels stijnmoreels added good first issue Good for newcomers area:logging All issues related to test logging. dependencies Pull requests that update a dependency file labels Nov 1, 2024
@stijnmoreels stijnmoreels added this to the v1.2 milestone Nov 1, 2024
@github-project-automation github-project-automation bot moved this to To do in Roadmap Nov 1, 2024
@stijnmoreels stijnmoreels modified the milestones: v1.2, v1.3 Nov 1, 2024
@stijnmoreels stijnmoreels modified the milestones: v1.3, v2.0 Nov 26, 2024
@stijnmoreels stijnmoreels moved this from To do to Pending Approval in Roadmap Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging All issues related to test logging. dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
Status: Pending Approval
Development

No branches or pull requests

1 participant