Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blob): deprecate unnecessary az blob functionality #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stijnmoreels
Copy link
Member

@stijnmoreels stijnmoreels commented Jan 24, 2025

Remove unnecessary/duplicated functionality on the TemporaryBlobFile that could/should already be configured on the container.

Developers are used to having delegates Func<...> when they see Where/Match functions. Having an extra type only overcomplicates things.

Closes #257
Closes #256

@stijnmoreels stijnmoreels requested a review from a team as a code owner January 24, 2025 06:08
BlobNameFilter.NameStartsWith("test-"),
BlobNameFilter.NameEndsWith("-123"),
BlobNameFilter.NameContains("test"));
options.OnSetup.CleanMatchingBlobs((BlobItem blob) => blob.Name.StartsWith("test-"));
Copy link
Member Author

@stijnmoreels stijnmoreels Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find this even more dev-friendly than the original. Let me know what you think.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for arcus-testing ready!

Name Link
🔨 Latest commit bb9add4
🔍 Latest deploy log https://app.netlify.com/sites/arcus-testing/deploys/67932e51c7956200084196aa
😎 Deploy Preview https://deploy-preview-258--arcus-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arcus-automation
Copy link
Collaborator

🧪 Code coverage summary

Metric Value
Line coverage 🟢 91.8%
Branch coverage 🟢 80.9%

Great job! 😎 Your code coverage is higher than my caffeine levels! ☕

@stijnmoreels stijnmoreels added enhancement New feature or request area:storage All issues related to Azure storage labels Feb 4, 2025
@stijnmoreels stijnmoreels changed the title chore: deprecate unnecessary az blob functionality chore(blob): deprecate unnecessary az blob functionality Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:storage All issues related to Azure storage enhancement New feature or request
Projects
None yet
2 participants