Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in Send command not respecting the timeout expectation #8

Open
disk91 opened this issue Jun 10, 2018 · 1 comment
Open

Problem in Send command not respecting the timeout expectation #8

disk91 opened this issue Jun 10, 2018 · 1 comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@disk91
Copy link

disk91 commented Jun 10, 2018

In code, you have timeout set for 10.000 ms or 60.000ms but in the loop you have 100ms loop
and you only divide timeout per 10. So your timeout is 10x what is needed

for (i = 0; i < timeout/10; i++)  <= This is a 10ms step ... not 100ms
  {
    if (digitalRead(interrupt_pin) == 0) {
      status();
      ret = statusCode(SIGFOX);
      break;
    } else {
      // THIS IS A 100ms loop
      digitalWrite(led_pin, HIGH);
      delay(50);
      digitalWrite(led_pin, LOW);
      delay(50);
    }
  }
@facchinm facchinm added the type: imperfection Perceived defect in any part of project label Jun 11, 2018
@facchinm
Copy link
Contributor

Hi @disk91 ,
thanks for finding this. In fact the timeout ends being much longer than expected but that code is only triggered in debugging mode so I don't think it will affect any real world project.
Anyway, I'm going to fix this in next library release, thanks!

@per1234 per1234 added the topic: code Related to content of the project itself label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants