Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of SET_PIN_MODE in global namespace clashes with popular Firmata library #233

Open
mphasize opened this issue Dec 22, 2022 · 1 comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@mphasize
Copy link

Hi there,

I've been trying for a while to compile either https://github.com/firmata/arduino or https://github.com/firmata/ConfigurableFirmata on the Arduino MKR WIFI 1010.

Unfortunately there seems to be a clash with the definition of SET_PIN_MODE in the global namespace here:

SET_PIN_MODE = 0x50,

The issue is also discussed here: firmata/arduino#470

Any ideas, how this could be solved?

@mphasize
Copy link
Author

A simple workaround is renaming SET_PIN_MODE to something else, as it is only used 3 times in the codebase. With this approach I could compile WiFiNINA and Firmata together and can get also create a working example.

Unfortunately, this is probably a somewhat unstable fix, but I don't know enough about C/C++ to refactor the code with a namespace.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants