-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFiServer operator bool #253
Open
JAndrassy
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
JAndrassy:server_op_bool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 6beb0b7
Click for full report table
Click for full report CSV
|
facchinm
approved these changes
Sep 22, 2023
JAndrassy
force-pushed
the
server_op_bool
branch
from
September 24, 2023 13:25
6beb0b7
to
12a5c9e
Compare
Memory usage change @ 12a5c9e
Click for full report table
Click for full report CSV
|
JAndrassy
force-pushed
the
server_op_bool
branch
from
September 24, 2023 13:41
12a5c9e
to
5f4c8f6
Compare
Memory usage change @ 5f4c8f6
Click for full report table
Click for full report CSV
|
JAndrassy
force-pushed
the
server_op_bool
branch
from
October 8, 2023 07:47
5f4c8f6
to
2b04572
Compare
Memory usage change @ 2b04572
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For other WiFi libraries it is a problem to implement proper server.status(), but easy to implement operator bool.
Server implementation in the Ethernet library has operator bool. WiFi101 has status(), but it just returns 0.
WiFiServer in esp32 Arduino WiFi library has only bool operator too.
So I thought WiFiNINA should have WiFiServer bool operator too.
overview of Server implementations in libraries https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#server-class