Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Change #3460

Merged
merged 8 commits into from
Oct 18, 2023
Merged

URL Change #3460

merged 8 commits into from
Oct 18, 2023

Conversation

AITINKR
Copy link
Contributor

@AITINKR AITINKR commented Oct 17, 2023

URL Change

@github-actions github-actions bot added the topic: submission Add library to the list label Oct 17, 2023
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/AITINKR/AITINKR_SHIELDS:

Linting library in AITINKR_SHIELDS
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 October 17, 2023 13:52
@github-actions
Copy link
Contributor

Hi @AITINKR.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: submission Add library to the list labels Oct 17, 2023
@github-actions github-actions bot removed the request for review from per1234 October 17, 2023 13:53
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/AITINKR/AITINKR_SHIELDS:

Linting library in AITINKR_SHIELDS
ERROR: Library name AITINKR_SHIELDS not found in the Library Manager index. Library names are not allowed to change     
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @AITINKR
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 October 17, 2023 13:54
@AITINKR
Copy link
Contributor Author

AITINKR commented Oct 17, 2023

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 October 17, 2023 14:01
@github-actions
Copy link
Contributor

Hi @AITINKR.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/AITINKR/AITINKR_SHIELDS:

Linting library in AITINKR_SHIELDS
ERROR: Library name AITINKR_SHIELDS not found in the Library Manager index. Library names are not allowed to change     
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @AITINKR
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 October 17, 2023 14:01
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Oct 17, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AITINKR. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Oct 17, 2023
Adding the AITINKR AIOT DEV BOARD Package
@github-actions github-actions bot requested review from per1234 and removed request for per1234 October 18, 2023 11:28
@github-actions github-actions bot removed the request for review from per1234 October 18, 2023 14:59
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AITINKR I see you made another commit to the main branch of your repository that adds the URL https://github.com/AITINKR/AITINKR_AIOT_DEVBOARD to the list.

All commits you add to a branch in your fork repository are included in the pull request that was submitted from that branch. You submitted this pull request from the main branch in your fork, so you MUST NOT push any additional commits to the main branch.

Please create a new branch in your fork, add the https://github.com/AITINKR/AITINKR_AIOT_DEVBOARD URL to the repositories.txt file in that branch, and then submit an additional pull request for the submission of https://github.com/AITINKR/AITINKR_AIOT_DEVBOARD.

If you have any questions or problems while doing that, just let me know and I'll provide assistance.

@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@arduino arduino deleted a comment from github-actions bot Oct 18, 2023
@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Oct 18, 2023
@MatteoPologruto MatteoPologruto self-assigned this Oct 18, 2023
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/10/18 14:54:55 Loaded 6280 libraries from DB
Removing AITINKR_SHEILDS
Success!

@github-actions
Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Oct 18, 2023
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/AITINKR/AITINKR_SHIELDS:

Linting library in AITINKR_SHIELDS
ERROR: Library name AITINKR_SHIELDS not found in the Library Manager index. Library names are not allowed to change     
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @MatteoPologruto
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 October 18, 2023 15:31
@MatteoPologruto MatteoPologruto merged commit 2527307 into arduino:main Oct 18, 2023
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Oct 18, 2023
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants