Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin can no longer be published #4

Closed
britter opened this issue Sep 17, 2020 · 3 comments
Closed

Plugin can no longer be published #4

britter opened this issue Sep 17, 2020 · 3 comments

Comments

@britter
Copy link
Contributor

britter commented Sep 17, 2020

@britter I tried to publish the new version, but now the first of the new tests "can be applied via plugins block" failed.
Do you have any idea whats the reason ? When I skip this test the other tests are succesful, but the first one always fail:

[result.txt](https://github.com/arendd/AspectjGradlePlugin/files/5239586/result.txt)

Originally posted by @arendd in #3 (comment)

@britter
Copy link
Contributor Author

britter commented Sep 17, 2020

Looking at the provided log I suspect that the Gradle version being used to publish the plugin is too old. The changes I applied probably need something above Gradle 5.x. Since the wrapper in this repository is not correctly set up, I'd suggest that we set up the wrapper with a Gradle version that supports the changes that I made.

This raises the question what the minimum supported Gradle version should be. I'm fairly confident that after my changes the plugin works with Gradle 5.x. Some 6.x version don't seem to be supported due to #1. We'll need to look into that later.

@britter
Copy link
Contributor Author

britter commented Sep 17, 2020

After some investigation I realized my changes from #3 don't work on Gradle 5.x. Since this plugin is supposed to work on Gradle 5/6 I need to find some other way to lazily evaluate the aspectjVersion. I need to think some more about this.

britter added a commit to britter/AspectjGradlePlugin that referenced this issue Sep 17, 2020
@arendd arendd closed this as completed in 010b220 Oct 2, 2020
@arendd
Copy link
Owner

arendd commented Oct 2, 2020

@britter Sorry for the delay, I merged your PR and successfully published version 0.0.5. Thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants