Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allow empty chunks #62

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Feat/allow empty chunks #62

merged 2 commits into from
Jan 22, 2025

Conversation

piellardj
Copy link
Member

This PR changes the ILocalMapData API:

  • allows empty chunks to not include data (it was not read anyways)
  • renaming from ILocalMapData to LocalMapData

@piellardj piellardj requested a review from Sceat January 19, 2025 16:33
@piellardj piellardj self-assigned this Jan 19, 2025
@Sceat
Copy link
Member

Sceat commented Jan 22, 2025

/merge

Copy link

Unable to merge, is this PR ready and approved ?

@Sceat Sceat force-pushed the feat/allow_empty_chunks branch from a274aee to 464bcd9 Compare January 22, 2025 03:18
@Sceat
Copy link
Member

Sceat commented Jan 22, 2025

@piellardj to be merged with fast forward (by the bot) it always require a git rebase master first

@Sceat
Copy link
Member

Sceat commented Jan 22, 2025

/merge

Copy link

Success! Fast forwarded master to feat/allow_empty_chunks! git checkout master && git merge feat/allow_empty_chunks --ff-only

@github-actions github-actions bot merged commit 464bcd9 into master Jan 22, 2025
2 checks passed
@piellardj piellardj deleted the feat/allow_empty_chunks branch January 25, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants