feat: enable debug config

arextest · Jan 2, 2024 · f3eafbe · f3eafbe
1 parent 674dd74
commit f3eafbe
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 24 deletions.
diff --git a/arex-instrumentation-foundation/src/main/java/io/arex/foundation/config/ConfigManager.java b/arex-instrumentation-foundation/src/main/java/io/arex/foundation/config/ConfigManager.java
@@ -330,31 +330,29 @@ private static Map<String, String> parseConfigFile(String configPath) {
 
     public void parseAgentConfig(String args) {
         Map<String, String> agentMap = StringUtil.asMap(args);
-        if (!agentMap.isEmpty()) {
-            for (Map.Entry<String, String> entry : agentMap.entrySet()) {
-                String key = entry.getKey();
-                String value = entry.getValue();
-                if (StringUtil.isEmpty(key) || StringUtil.isEmpty(value)) {
-                    continue;
-                }
-
-                switch (key) {
-                    case ENABLE_DEBUG:
-                        setEnableDebug(value);
-                        break;
-                    case STORAGE_SERVICE_MODE:
-                        setStorageServiceMode(value);
-                        break;
-                    case STORAGE_SERVICE_HOST:
-                    case DISABLE_MODULE:
-                        continue;
-                    default:
-                        System.setProperty(key, value);
-                        break;
-                }
+        if (agentMap.isEmpty()) {
+            return;
+        }
+        for (Map.Entry<String, String> entry : agentMap.entrySet()) {
+            String key = entry.getKey();
+            String value = entry.getValue();
+
+            switch (key) {
+                case ENABLE_DEBUG:
+                    setEnableDebug(value);
+                    break;
+                case STORAGE_SERVICE_MODE:
+                    setStorageServiceMode(value);
+                    break;
+                case STORAGE_SERVICE_HOST:
+                case DISABLE_MODULE:
+                    break;
+                default:
+                    System.setProperty(key, value);
+                    break;
             }
-            updateRuntimeConfig();
         }
+        updateRuntimeConfig();
     }
 
     public void updateConfigFromService(ResponseBody serviceConfig) {
@@ -385,6 +383,7 @@ private void updateRuntimeConfig() {
         Map<String, String> extendFieldMap = getExtendField();
         if (MapUtils.isNotEmpty(extendFieldMap)) {
             configMap.putAll(extendFieldMap);
+            setEnableDebug(extendFieldMap.get(ENABLE_DEBUG));
         }
 
         ConfigBuilder.create(getServiceName())

diff --git a/...instrumentation-foundation/src/test/java/io/arex/foundation/config/ConfigManagerTest.java b/...instrumentation-foundation/src/test/java/io/arex/foundation/config/ConfigManagerTest.java
@@ -103,7 +103,7 @@ void replaceConfigFromService() {
 
     @Test
     void parseAgentConfig() {
-        configManager.parseAgentConfig("arex.storage.mode=xxx;arex.enable.debug=true");
+        configManager.parseAgentConfig("arex.storage.mode=xxx;arex.enable.debug=true;arex.disable.instrumentation.module=dynamic;arex.buffer.size=1024;arex.serializer.config=");
         assertTrue(configManager.isEnableDebug());
     }