Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lettuce cluster #368

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: support lettuce cluster #368

merged 2 commits into from
Jan 17, 2024

Conversation

DanLi39
Copy link
Collaborator

@DanLi39 DanLi39 commented Jan 3, 2024

fix: #321

@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch from 93cf67a to f54de5e Compare January 3, 2024 12:26
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 503 lines in your changes are missing coverage. Please review.

Comparison is base (664afac) 61.90% compared to head (313f65c) 66.81%.

Files Patch % Lines
...is/common/lettuce/wrapper/RedisCommandWrapper.java 0.00% 213 Missing ⚠️
...n/lettuce/wrapper/RedisReactiveCommandWrapper.java 8.05% 194 Missing ⚠️
.../redis/common/lettuce/RedisCommandBuilderImpl.java 0.00% 18 Missing ⚠️
.../cluster/RedisClusterAsyncCommandsImplWrapper.java 89.70% 14 Missing ⚠️
.../cluster/RedisClusterAsyncCommandsImplWrapper.java 89.78% 14 Missing ⚠️
...uster/RedisClusterReactiveCommandsImplWrapper.java 90.24% 12 Missing ⚠️
...uster/RedisClusterReactiveCommandsImplWrapper.java 90.76% 12 Missing ⚠️
.../inst/redis/common/lettuce/LettuceClusterUtil.java 47.05% 7 Missing and 2 partials ⚠️
...rex/inst/dynamic/common/DynamicClassExtractor.java 55.55% 4 Missing ⚠️
...efulRedisClusterConnectionImplInstrumentation.java 86.66% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #368      +/-   ##
============================================
+ Coverage     61.90%   66.81%   +4.90%     
- Complexity     2542     3259     +717     
============================================
  Files           321      332      +11     
  Lines         12066    12368     +302     
  Branches       1442     1475      +33     
============================================
+ Hits           7470     8264     +794     
+ Misses         3923     3445     -478     
+ Partials        673      659      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanLi39 DanLi39 changed the title feat: support redis cluster in lettuce feat: support lettuce cluster Jan 4, 2024
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch from f54de5e to 3556206 Compare January 4, 2024 06:40
@DanLi39 DanLi39 requested review from mr3, YongwuHe and mengqcc January 4, 2024 06:41
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch 2 times, most recently from 8315b0e to 68a23c9 Compare January 4, 2024 10:58
@DanLi39 DanLi39 self-assigned this Jan 4, 2024
@DanLi39 DanLi39 added the enhancement ⭐ New feature or request label Jan 4, 2024
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch 2 times, most recently from 6909d9b to 5b3ff90 Compare January 4, 2024 11:56
@mr3 mr3 requested a review from lucas-myx January 4, 2024 14:55
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch 7 times, most recently from 46e4274 to 44da33a Compare January 8, 2024 03:50
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch 4 times, most recently from e2a97ab to 6e14ccc Compare January 15, 2024 09:12
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch from 6e14ccc to f230eb0 Compare January 15, 2024 12:33
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch 7 times, most recently from 587a02e to d6c729c Compare January 17, 2024 07:58
lucas-myx
lucas-myx previously approved these changes Jan 17, 2024
mr3
mr3 previously approved these changes Jan 17, 2024
@DanLi39 DanLi39 dismissed stale reviews from mr3 and lucas-myx via 313f65c January 17, 2024 08:03
@DanLi39 DanLi39 force-pushed the feat/supportLettuceCluster branch from d6c729c to 313f65c Compare January 17, 2024 08:03
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

54.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@DanLi39 DanLi39 enabled auto-merge (squash) January 17, 2024 08:19
@DanLi39 DanLi39 disabled auto-merge January 17, 2024 08:20
@DanLi39 DanLi39 merged commit c5c1b1e into main Jan 17, 2024
7 of 8 checks passed
@DanLi39 DanLi39 deleted the feat/supportLettuceCluster branch January 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⭐ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis 请求未录制
4 participants