Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support flux type in dynamic #372

Merged
merged 1 commit into from
Jan 11, 2024
Merged

feat: support flux type in dynamic #372

merged 1 commit into from
Jan 11, 2024

Conversation

DanLi39
Copy link
Collaborator

@DanLi39 DanLi39 commented Jan 8, 2024

No description provided.

@DanLi39 DanLi39 added the enhancement ⭐ New feature or request label Jan 8, 2024
@DanLi39 DanLi39 self-assigned this Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c2f84d7) 60.43% compared to head (4d8f7af) 60.64%.
Report is 2 commits behind head on main.

Files Patch % Lines
...va/io/arex/agent/bootstrap/internal/WeakCache.java 0.00% 0 Missing and 1 partial ⚠️
...c/main/java/io/arex/inst/common/util/FluxUtil.java 97.14% 0 Missing and 1 partial ⚠️
...rex/inst/dynamic/common/DynamicClassExtractor.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #372      +/-   ##
============================================
+ Coverage     60.43%   60.64%   +0.20%     
- Complexity     2453     2470      +17     
============================================
  Files           319      321       +2     
  Lines         12000    12066      +66     
  Branches       1432     1441       +9     
============================================
+ Hits           7252     7317      +65     
+ Misses         4091     4090       -1     
- Partials        657      659       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanLi39 DanLi39 force-pushed the feat/supportDynamicFlux branch 6 times, most recently from 873fd75 to cf647eb Compare January 10, 2024 02:58
@DanLi39 DanLi39 force-pushed the feat/supportDynamicFlux branch 6 times, most recently from 3be3b57 to 7901e91 Compare January 10, 2024 10:43
@DanLi39 DanLi39 force-pushed the feat/supportDynamicFlux branch 4 times, most recently from 00a34ff to 378a723 Compare January 10, 2024 12:03
lucas-myx
lucas-myx previously approved these changes Jan 10, 2024
View reviewed changes
@DanLi39 DanLi39 force-pushed the feat/supportDynamicFlux branch from 378a723 to 4028e94 Compare January 11, 2024 03:53
@DanLi39 DanLi39 force-pushed the feat/supportDynamicFlux branch from 4028e94 to 4d8f7af Compare January 11, 2024 08:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DanLi39 DanLi39 merged commit 7daff2b into main Jan 11, 2024
8 checks passed
@DanLi39 DanLi39 deleted the feat/supportDynamicFlux branch January 11, 2024 09:06
DanLi39 added a commit that referenced this pull request Jan 15, 2024
@DanLi39
feat: support flux type in dynamic (#372)
72960c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr3 mr3 mr3 left review comments

@lucas-myx lucas-myx lucas-myx approved these changes

@YongwuHe YongwuHe YongwuHe approved these changes

@mengqcc mengqcc Awaiting requested review from mengqcc

Assignees

@DanLi39 DanLi39

Labels
enhancement ⭐ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanLi39 @mr3 @lucas-myx @YongwuHe