Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor llms and embeddings subpackages into models subpackage #1040

Open
gabrielmbmb opened this issue Oct 18, 2024 · 0 comments · May be fixed by #1045
Open

[FEATURE] Refactor llms and embeddings subpackages into models subpackage #1040

gabrielmbmb opened this issue Oct 18, 2024 · 0 comments · May be fixed by #1045
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gabrielmbmb
Copy link
Member

Description

We started distilabel with only llms, later we've added embeddings and we foresee that we will add more kind of models. We need to refactor these subpackages to create a new subpackage called models containining the llms and embeddings, and extracting the llms/mixins to models/mixins.

@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Oct 18, 2024
@gabrielmbmb gabrielmbmb added this to the 1.5.0 milestone Oct 18, 2024
@gabrielmbmb gabrielmbmb self-assigned this Oct 18, 2024
@plaguss plaguss assigned plaguss and unassigned gabrielmbmb Oct 24, 2024
@plaguss plaguss linked a pull request Oct 24, 2024 that will close this issue
@plaguss plaguss linked a pull request Oct 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants