Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish off UI changes for OCI support #21685

Open
keithchong opened this issue Jan 27, 2025 · 0 comments
Open

Polish off UI changes for OCI support #21685

keithchong opened this issue Jan 27, 2025 · 0 comments
Labels
enhancement New feature or request oci-integration Argo CD OCI Integration

Comments

@keithchong
Copy link
Contributor

Summary

Here are some items that should be done on top of the OCI support PR that Blake added. These changes are mostly cosmetic and are not blockers to the main feature. (However, IMHO, I'd fix point 2 as part of the PR). @blakepettersson , if you prefer, you can make the changes as part of your PR, or, this can be done separately.

  1. Missing icon in the Repo List settings view ( PR merged fix: Add OCI icon argo-ui#583 . Just needs to be pulled into Argo CD)
  2. Revision SHA must be truncated in the History and Rollback page. Specifically, in revision-metadata-rows.tsx. The text overflows past the card boundary on the right.
  3. SHA should be truncated in the Last Sync Panel. It is truncated in the Sync Status Panel. This is to be consistent with the other commit SHAs that are displayed, and this design goes back a very long time. See screenshots. It should be truncated so the panel does not grab all its preferred horizontal space, which as it stands makes the panel look unbalanced.
  4. The point is for the panel that slides open after the More button from the Last Sync Panel (and similarly for Sync Status) is clicked. (eg. See application-details.tsx)
  • The revision version could be truncated as well, but it's not as bad here since this panel is a "More details" panel.
  • There is an OCI image field and an Image URL, which might be redundant
  • The Image URL link is 'empty' (These last two points can possibly be done as part of Blake's PR since it is a minor change)

Motivation

See PR

Proposal

See PR

Screenshots

Image Image
@keithchong keithchong added enhancement New feature or request oci-integration Argo CD OCI Integration labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request oci-integration Argo CD OCI Integration
Projects
None yet
Development

No branches or pull requests

1 participant