You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some items that should be done on top of the OCI support PR that Blake added. These changes are mostly cosmetic and are not blockers to the main feature. (However, IMHO, I'd fix point 2 as part of the PR). @blakepettersson , if you prefer, you can make the changes as part of your PR, or, this can be done separately.
Missing icon in the Repo List settings view ( PR merged fix: Add OCI icon argo-ui#583 . Just needs to be pulled into Argo CD)
Revision SHA must be truncated in the History and Rollback page. Specifically, in revision-metadata-rows.tsx. The text overflows past the card boundary on the right.
SHA should be truncated in the Last Sync Panel. It is truncated in the Sync Status Panel. This is to be consistent with the other commit SHAs that are displayed, and this design goes back a very long time. See screenshots. It should be truncated so the panel does not grab all its preferred horizontal space, which as it stands makes the panel look unbalanced.
The point is for the panel that slides open after the More button from the Last Sync Panel (and similarly for Sync Status) is clicked. (eg. See application-details.tsx)
The revision version could be truncated as well, but it's not as bad here since this panel is a "More details" panel.
There is an OCI image field and an Image URL, which might be redundant
The Image URL link is 'empty' (These last two points can possibly be done as part of Blake's PR since it is a minor change)
Summary
Here are some items that should be done on top of the OCI support PR that Blake added. These changes are mostly cosmetic and are not blockers to the main feature. (However, IMHO, I'd fix point 2 as part of the PR). @blakepettersson , if you prefer, you can make the changes as part of your PR, or, this can be done separately.
Motivation
See PR
Proposal
See PR
Screenshots
The text was updated successfully, but these errors were encountered: