Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter can't run locally #21713

Open
crenshaw-dev opened this issue Jan 29, 2025 · 2 comments
Open

Linter can't run locally #21713

crenshaw-dev opened this issue Jan 29, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@crenshaw-dev
Copy link
Member

Running make lint-local always dies after a few minutes with Killed: 9, probably due to OOM.

I've tuned ARGOCD_LINT_GOGC with no luck.

We should look into finding ways to make the linter run more efficiently locally. Maybe we should disable some high-cost, low-value rules if possible.

@crenshaw-dev crenshaw-dev added the bug Something isn't working label Jan 29, 2025
@crenshaw-dev
Copy link
Member Author

cc @mmorel-35 for visibility, but don't feel obligated to dive into this. The new lint rules are helpful, just wanna eventually find a way to improve the local dev experience.

@mmorel-35
Copy link
Contributor

Do you use GOMEMLIMIT with golangci-lint ? See this article for more context if you need to : https://weaviate.io/blog/gomemlimit-a-game-changer-for-high-memory-applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants