Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor code and cleanup claims usage #21715

Open
agaudreault opened this issue Jan 30, 2025 · 1 comment
Open

refactor code and cleanup claims usage #21715

agaudreault opened this issue Jan 30, 2025 · 1 comment
Labels
component:auth refactoring Refactoring required

Comments

@agaudreault
Copy link
Member

agaudreault commented Jan 30, 2025

Summary

RegisteredClaims and MapClaims are used in the code, and ArgoClaims is wrapping RegisteredClaims. How we access the claims then is either through interface methods, property access or with jwt helper functions to convert the values of MapClaims.

The current code is confusing, error prone and not necessary.

Motivation

  • less serializations means faster code
  • code is easier to understand
  • less chance of error

Proposal

Use the ArgoClaims wrapper everywhere.

@agaudreault agaudreault added component:auth refactoring Refactoring required labels Jan 30, 2025
@sbin64
Copy link

sbin64 commented Jan 30, 2025

/assign

sorry @agaudreault could you elaborate more on that? Which specific files do you want to get through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:auth refactoring Refactoring required
Projects
None yet
Development

No branches or pull requests

2 participants