From 99076623280eaf91d822a8a6de706338f80a1428 Mon Sep 17 00:00:00 2001
From: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Date: Thu, 31 Oct 2024 17:19:57 -0400
Subject: [PATCH] Prep for review

---
 .github/actions/bench/action.yml             |  2 +-
 .github/workflows/bench.yml                  | 63 --------------------
 kadena/light-client/benches/longest_chain.rs |  4 +-
 3 files changed, 3 insertions(+), 66 deletions(-)

diff --git a/.github/actions/bench/action.yml b/.github/actions/bench/action.yml
index 6bd98e3a..03e33510 100644
--- a/.github/actions/bench/action.yml
+++ b/.github/actions/bench/action.yml
@@ -79,7 +79,7 @@ runs:
       run: |
         COMMIT=$(git rev-parse HEAD)
         ID=${{ steps.commit-comment.outputs.comment-id }}
-        echo "[Commit comment](https://github.com/${{ github.repository }}/commit/$COMMIT#commit-comment-$ID)" | tee -a summary.md
+        echo "[Commit comment](https://github.com/${{ github.repository }}/commit/$COMMIT#commitcomment-$ID)" | tee -a summary.md
 
         echo "report<<EOF" >> $GITHUB_OUTPUT
         cat summary.md >> $GITHUB_OUTPUT
diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
index 0ee07efb..ccbae067 100644
--- a/.github/workflows/bench.yml
+++ b/.github/workflows/bench.yml
@@ -10,9 +10,6 @@
 # It runs all light client benchmarks and sends them to Zulip
 name: Light client benchmark
 on:
-  push:
-    branches:
-      - "ci-bench"
   schedule:
     # Full report on Thursday, 2pm UTC
     - cron: '0 14 * * 4'
@@ -201,63 +198,3 @@ jobs:
           # Ignored if `type: private`
           topic: "${{ env.TOPIC }}"
           content: "${{ steps.run-benchmark.outputs.report }}"
-
-
-  benchmark-test:
-    name: LC bench (test)
-    runs-on: warp-custom-r7iz-metal-32xl
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - light-client: aptos
-            benchmark: inclusion
-          - light-client: aptos
-            benchmark: epoch_change
-          - light-client: ethereum
-            benchmark: inclusion
-          - light-client: ethereum
-            benchmark: committee_change
-          - light-client: kadena
-            benchmark: spv
-          - light-client: kadena
-            benchmark: longest_chain
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          repository: argumentcomputer/ci-workflows
-      - uses: ./.github/actions/ci-env
-      - uses: actions/checkout@v4
-      - name: Setup CI
-        uses: ./.github/actions/setup
-      - name: Set env
-        run: |
-          # Default benchmark settings optimized for light clients, can be overwritten with `env` input
-          echo "RUSTFLAGS=-C target-cpu=native --cfg tokio_unstable -C opt-level=3" | tee -a $GITHUB_ENV
-          echo "SHARD_SIZE=4194304" | tee -a $GITHUB_ENV
-          echo "SHARD_BATCH_SIZE=0" | tee -a $GITHUB_ENV
-          echo "RECONSTRUCT_COMMITMENTS=false" | tee -a $GITHUB_ENV
-          echo "SHARD_CHUNKING_MULTIPLIER=1" | tee -a $GITHUB_ENV
-          echo "MODE=SNARK" | tee -a $GITHUB_ENV
-      - name: Set Zulip env
-        run: |
-          echo "TYPE=private" | tee -a $GITHUB_ENV
-          echo "STREAM=11" | tee -a $GITHUB_ENV
-          echo "TOPIC=" | tee -a $GITHUB_ENV
-      - name: Run benchmark and create report
-        id: run-benchmark
-        uses: ./.github/actions/bench
-        with:
-          light-client: ${{ matrix.light-client }}
-          benchmark: ${{ matrix.benchmark }}
-      - name: Send report to Zulip
-        uses: zulip/github-actions-zulip/send-message@v1
-        with:
-          api-key: ${{ secrets.ZULIP_API_KEY }}
-          email: "aineko-bot@zulip.lurk-lab.com"
-          organization-url: "https://zulip.argument.xyz"
-          to: "${{ env.STREAM }}"
-          type: "${{ env.TYPE }}"
-          # Ignored if `type: private`
-          topic: "${{ env.TOPIC }}"
-          content: "${{ steps.run-benchmark.outputs.report }}"
diff --git a/kadena/light-client/benches/longest_chain.rs b/kadena/light-client/benches/longest_chain.rs
index 9ec9c547..4c0a120d 100644
--- a/kadena/light-client/benches/longest_chain.rs
+++ b/kadena/light-client/benches/longest_chain.rs
@@ -29,7 +29,7 @@ impl BenchmarkAssets {
 #[derive(Debug, Clone, Serialize)]
 struct BenchResults {
     proving_time: u128,
-    verification_time: u128,
+    verifying_time: u128,
 }
 
 fn main() {
@@ -65,7 +65,7 @@ fn main() {
     // Print results
     let results = BenchResults {
         proving_time: proving_time.as_millis(),
-        verification_time: verifying_time.as_millis(),
+        verifying_time: verifying_time.as_millis(),
     };
 
     println!("{}", serde_json::to_string(&results).unwrap());