Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client should be fail if all retries failed #50

Closed
sksat opened this issue Jan 30, 2024 · 0 comments · Fixed by #51
Closed

Client should be fail if all retries failed #50

sksat opened this issue Jan 30, 2024 · 0 comments · Fixed by #51
Assignees
@namachan10777
Labels
invalid This doesn't seem right

Comments

@sksat
Copy link
Member

sksat commented Jan 30, 2024

Client-side retry functionality was implemented in #34.
But if all attempts fail, the current implementation terminates the gh-federation step normally without error.
This behavior makes it difficult to investigate problems in the gh-federation backend.
@sksat sksat added the invalid This doesn't seem right label Jan 30, 2024
@namachan10777 namachan10777 self-assigned this Feb 7, 2024
@namachan10777 namachan10777 mentioned this issue Feb 7, 2024
Merged
@sksat sksat linked a pull request Feb 7, 2024 that will close this issue
Exit with error code if gh-federation failed #51
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namachan10777 namachan10777

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exit with error code if gh-federation failed arkedge/gh-federation
2 participants
@namachan10777 @sksat