Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Collections of small future improvements #266

Open
5 tasks
igorpecovnik opened this issue Nov 22, 2024 · 1 comment
Open
5 tasks

[Task]: Collections of small future improvements #266

igorpecovnik opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
Task/To-Do Project management: To-Do or task(s) someone is working on

Comments

@igorpecovnik
Copy link
Member

igorpecovnik commented Nov 22, 2024

Task description

Let's assemble a list first, coding starts when this note is removed.

  • Show actual IP address in the dialog box after installing applications. Currently it shows: https://<your.IP>:8123 - > $LOCALIPADD but we need to keep this as is in the documentation.
  • align filenames of modules. Some sections are O.K., some not
  • make sure all modules have identical headers (do we have a function that returns true if header have all expected field?)
  • documentation should have a link to the module sources
  • when using apt for uninstall, use apt-get autopurge to also remove dandling dependencies
@igorpecovnik igorpecovnik added the Task/To-Do Project management: To-Do or task(s) someone is working on label Nov 22, 2024
@Tearran
Copy link
Member

Tearran commented Nov 23, 2024

To dynamically change the menu sub sub menu titles update_sub_submenu_data in config.runtime.sh

Adding a Data point should not break things. but will need to refactor the doc and generate_json_options.

["module_name,port"]="<port number>"

Updating the menu to show the port

update_sub_submenu_data "ID" "SUB_ID" "SUB_SUB_ID" "$LOCALIPADD:${module_options["module_name,port"]}"

SImple verify
example cockpit and webmin

# Sub sub menu updates
cockpit_port=$(lsof -iTCP:9090 -sTCP:LISTEN | grep systemd )
if [[ -n "$cockpit_port" ]]; then
	update_sub_submenu_data "Software" "Management" "MAN004" "https://$LOCALIPADD:9090"
fi
#
webmin_port=$(lsof -iTCP:10000 -sTCP:LISTEN | grep webmin )
if [[ -n "$webmin_port" ]]; then
	update_sub_submenu_data "Software" "Management" "MAN005" "https://$LOCALIPADD:10000"
fi

containers would be something like | grep docker-pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task/To-Do Project management: To-Do or task(s) someone is working on
Projects
None yet
Development

No branches or pull requests

3 participants