You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When trying to retrieve the comments of a PR, the process fails with a message saying that sort only takes 2 arguments. The linter also complains about the same in the following line:
@lhernanz Please follow the bug report template and tell me what is the version of Emacs you are using.
The latest consult-gh code requires Emacs>30.0, which was not set correctly in the headers. I just pushed an update to change the requirements and made a new release as well.
Note that if you are on Emacs<30.0, you can use older releases <v1.0, which do not have the latest features, for example the full issue/pr commenting and review features. Alternatively, you can still use the latest consult-gh but have to customize the package to use a different issue or pr view action.
I am sorry, you are absolutely right, I should have included the Emacs version that I am using (29.4). I completely missed the version 30 angle as the package was not marked as requiring 30.
Describe the bug
When trying to retrieve the comments of a PR, the process fails with a message saying that sort only takes 2 arguments. The linter also complains about the same in the following line:
https://github.com/armindarvish/consult-gh/blame/28f472574b05647ffdff1d265e28b91250404241/consult-gh.el#L4565
It seems that the ':key' parameter should not be there.
To Reproduce
Steps to reproduce the behavior:
Use
consult-gh-pr-list
to try to retrieve the comments of a PR and it will fail.Expected behavior
You can see the details of the PR without the
sort
related error.The text was updated successfully, but these errors were encountered: