-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for all day events (#55) #61
Conversation
@cuvar Thanks. I will get back to you in a couple days. I will have to check the RFC(s) for what it says it should be too. However;
They are the same value. |
cool, thanks! I'll add another commit regarding the |
Thanks. @cuvar What I'm thinking is that this changes behaviour, so how about we just duplicate the functions and append Another approach would be to make it do a better job at detecting the format of the date/time being used. |
I'm sorry, but unfortunately I won't have the time to dive into the code in the next time. Therefore, I just created this shallow fix. If there's more time, I'll have a look into it again. |
@cuvar Thanks though. Perhaps someone else will come and pick up this PR. Did you get your problem solved at all? If not I can figure something out. What timezone are you? |
Thanks! Yes, it seems to have solved my issue. My timezone is UTC+1 |
I will still look into this when I get some time to work on this project. |
Hopefully, this implementation should fix #55. At least, this solutions seems to have worked for me. I took @kevinmorio's approach mentioned in the issue here.