Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: AM doesn't have a notion of public URL #1140

Closed
sevein opened this issue Jun 13, 2018 · 3 comments
Closed

Problem: AM doesn't have a notion of public URL #1140

sevein opened this issue Jun 13, 2018 · 3 comments
Assignees
Labels
Jisc RDSS Status: in progress Issue that is currently being worked on. Waffle label. Type: documentation
Milestone

Comments

@sevein
Copy link
Member

sevein commented Jun 13, 2018

The self-registration process that AM performs against SS (during the installation) is sometimes insufficient because the pipeline details does not include an accessible URL so SS can reach the pipeline.

The request made by storageService during the registration is similar to the one produced with the following command:

curl -s -d '{
        "uuid": "99354557-9e6e-4918-9fe3-a65b00ecb199",
        "description": "Test pipeline",
        "create_default_locations": true,
    }' \
        -X POST \
        -H "Authorization: ApiKey test:test" \
        -H "Content-Type: application/json" \
            "http://127.0.0.1:8000/api/v2/pipeline/"

The remote_name value is not used. When unset, SS populates that property after the value found in the REMOTE_ADDR HTTP header - this is okay as a fallback but we want AM to learn a new site_url setting that the user can set. This value would be used during the self-registration process.

In RDSS, this was solved differently. See JiscSD/archivematica-storage-service#22. for more details.

@sevein sevein added Status: in progress Issue that is currently being worked on. Waffle label. Jisc RDSS labels Jun 13, 2018
@sevein sevein self-assigned this Jun 13, 2018
@sevein sevein added this to the 1.8.0 milestone Jun 14, 2018
@sevein sevein added Status: review The issue has been merged and is ready for review. Waffle label. and removed Status: in progress Issue that is currently being worked on. Waffle label. labels Jun 28, 2018
@sevein sevein removed their assignment Sep 24, 2018
@peterVG peterVG removed their assignment Oct 10, 2018
@sromkey
Copy link
Contributor

sromkey commented Oct 12, 2018

This is connected to #1142 and since the setting is very much there (under Administration, General) I'm calling this verified!

@sromkey sromkey added Status: verified and removed Status: review The issue has been merged and is ready for review. Waffle label. labels Oct 12, 2018
@sromkey
Copy link
Contributor

sromkey commented Oct 12, 2018

Whoops, jumped the gun, we still need to document this! Assigning myself.

@sromkey sromkey self-assigned this Oct 12, 2018
@sromkey sromkey added Status: review The issue has been merged and is ready for review. Waffle label. and removed Status: verified labels Oct 12, 2018
@sallain sallain assigned sallain and unassigned sromkey Oct 24, 2018
qubot pushed a commit to artefactual/archivematica-docs that referenced this issue Oct 24, 2018
This change adds information about the Site URL field on the Administration
tab -> General configuration page. It also updates the associated screenshot
and reformats some field information for style guide consistency.

Connected to artefactual/archivematica#1140
qubot pushed a commit to artefactual/archivematica-docs that referenced this issue Oct 24, 2018
This change adds information about the Site URL field on the Administration
tab -> General configuration page. It also updates the associated screenshot
and reformats some field information for style guide consistency.

Connected to artefactual/archivematica#1140
qubot pushed a commit to artefactual/archivematica-docs that referenced this issue Oct 24, 2018
This change adds information about the Site URL field on the Administration
tab -> General configuration page. It also updates the associated screenshot
and reformats some field information for style guide consistency.

Connected to artefactual/archivematica#1140
@sallain
Copy link
Member

sallain commented Oct 24, 2018

Documented and added to release notes.

@sallain sallain added Status: verified and removed Status: review The issue has been merged and is ready for review. Waffle label. labels Oct 24, 2018
@sromkey sromkey closed this as completed Nov 22, 2018
@replaceafill replaceafill added the Status: in progress Issue that is currently being worked on. Waffle label. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jisc RDSS Status: in progress Issue that is currently being worked on. Waffle label. Type: documentation
Projects
None yet
Development

No branches or pull requests

5 participants