-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate missing french translations in qtAccessionPlugin #1627
Comments
Took me a while to figure this out. Turns out this stems from a misplaced This translation needs to be corrected on Weblate (there should be no space between gt and Ideally atom/vendor/symfony/lib/i18n/sfMessageSource_XLIFF.class.php Lines 54 to 59 in d996e1c
|
Throwing an exception when Symfony runs into issues when loading XLIFF files. This will help with catching broken XML files due to translation errors. Without any error handling, this would lead Symfony to use an empty array as the array of translations when it is unable to read XML files, and would make it delete all existing translations for such a file.
I've fixed the problem string in Weblate as well, and it is now just awaiting review. |
Throwing an exception when Symfony runs into issues when loading XLIFF files. This will help with catching broken XML files due to translation errors. Without any error handling, this would lead Symfony to use an empty array as the array of translations when it is unable to read XML files, and would make it delete all existing translations for such a file.
Throwing an exception when Symfony runs into issues when loading XLIFF files. This will help with catching broken XML files due to translation errors. Without any error handling, this would lead Symfony to use an empty array as the array of translations when it is unable to read XML files, and would make it delete all existing translations for such a file.
PR has been merged but leaving this open until the Weblate translation that was causing problems is approved. |
Weblate translation has been approved! |
Linked to this Redmine issue. French translations for this plugin seem to be dropped when running a pull from weblate, and trying to import the existing translations (currently present in the 2.7.3 release) into the translations repo seems to have no effect.
It's important to note that unless this issue is fixed, french translations for this file will always be dropped when running a translation pull.
The text was updated successfully, but these errors were encountered: