Investigate missing french translations in qtAccessionPlugin

[anvit]

Linked to this Redmine issue. French translations for this plugin seem to be dropped when running a pull from weblate, and trying to import the existing translations (currently present in the 2.7.3 release) into the translations repo seems to have no effect.

It's important to note that unless this issue is fixed, french translations for this file will always be dropped when running a translation pull.

[anvit]

Took me a while to figure this out. Turns out this stems from a misplaced ; in a weblate translation, which results in an invalid HTML entity which prevents the translation XML file being loaded.

This translation needs to be corrected on Weblate (there should be no space between gt and ; here):

Ideally vendor/symfony/lib/i18n/sfMessageSource_XLIFF.class.php should have been throwing an exception instead of silently returning false given that Symfony's Message Source load/read functions simply expect loadData to return an array of translations and do not handle this false value on their end.

atom/vendor/symfony/lib/i18n/sfMessageSource_XLIFF.class.php

Lines 54 to 59 in d996e1c

	if (!$xml = simplexml_load_file($filename))
	{
	$error = false;
	return $error;
	}

[anvit]

I've fixed the problem string in Weblate as well, and it is now just awaiting review.

[anvit]

PR has been merged but leaving this open until the Weblate translation that was causing problems is approved.

[anvit]

Weblate translation has been approved!