Problem with Pull method in AfcService

[btraktirnik]

Hi,

The Pull method isn't working. I assume that the problem is because the inner implementation of the Pull method contains the following line which is problematic:

if (OperatingSystem.IsWindows()) {
    // Windows filesystems can't cope with ':' so we replace these with '-'
    dstPath = dstPath.Replace(':', '-');
}

The above code will convert for example: c:\users\user1\docs to c-\users\user1\docs which is invalid path.

Thanks,
Boris.

[artehe]

Yes you're right that could be the case if you're writing to an absolute path in Windows that includes a driver letter at the start.

I remember putting this in as some of the files I was pulling out had ':' in the path, but when I was testing it I was only using relative paths 🤦

PR #85 should fix this (hopefully permanently), if you could test it out and verify for me that'd be great!

[btraktirnik]

Working great
Thanks!