Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Robolectric on DeveloperSettingsTest #120

Closed
lenguyenthanh opened this issue Mar 14, 2016 · 4 comments
Closed

Get rid of Robolectric on DeveloperSettingsTest #120

lenguyenthanh opened this issue Mar 14, 2016 · 4 comments

Comments

@lenguyenthanh
Copy link
Contributor

As I see we are using Robolectric to test DeveloperSetting class because DeveloperSetting needs an instance of SharedPreferences.

Instead of user Robolectric to get SharedPreferences instance we can use some kind of mock or in memory Shared preferences. In my opinion, It will be better approach than using Robolectric.

Or we can use this instead of SharedPreferences directly on DeveloperSetting class. It will make mocking stuffs easy.

@vanniktech
Copy link
Contributor

#53 is basically saying the same

@lenguyenthanh
Copy link
Contributor Author

Thanks @vanniktech for reminding me, I joined #53 conversation too, but totally forgot.
Has any PR for it yet?

@vanniktech
Copy link
Contributor

AFAIK not yet

@artem-zinnatullin
Copy link
Owner

Yup, let's close this as duplicate and fix #53 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants